From: Marc Dionne <marc.c.dionne@gmail.com>
To: linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: fix boot panic with SATAPI devices on non-SFF
Date: Sat, 19 Apr 2008 19:52:24 -0400 [thread overview]
Message-ID: <480A85B8.7030403@gmail.com> (raw)
> If it's a panic with a SATA drive, then no it wouldn't ... the problem I
> fixed was in SATAPI only (That's CD/DVD/Tape devices). If you actually
> post the boot log and panic, linux-ide and Tejun might be able to help.
> Your brief snippet indicates the controller isn't finding sda, I think.
>
> James
Hi,
My system (nforce4 SATA) is also unbootable with commit 305d2a1a applied. I
verified that it works fine with current git with just that commit reverted.
After analyzing a bit more, I found that the key is in the slightly changed
logic in ata_do_reset(). Previously, devices were changed from class
ATA_DEV_UNKNOWN to ATA_DEV_NONE only if one device was found to be !UNKNOWN, but
now the change is systematic. Since my SATA disk is by itself on the port, this
makes it become ATA_DEV_NONE where previously it was left as ATA_DEV_UNKNOWN
when ata_do_reset() returned.
Changing this makes the system bootable again.
Cheers,
Marc
reply other threads:[~2008-04-19 23:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480A85B8.7030403@gmail.com \
--to=marc.c.dionne@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).