Re: [PATCH] libata: fix boot panic with SATAPI devices on non-SFF

Re: [PATCH] libata: fix boot panic with SATAPI devices on non-SFF

[Marc Dionne]

 > If it's a panic with a SATA drive, then no it wouldn't ... the problem I
 > fixed was in SATAPI only (That's CD/DVD/Tape devices).  If you actually
 > post the boot log and panic, linux-ide and Tejun might be able to help.
 > Your brief snippet indicates the controller isn't finding sda, I think.
 >
 > James

Hi,

My system (nforce4 SATA) is also unbootable with commit 305d2a1a applied.  I 
verified that it works fine with current git with just that commit reverted.

After analyzing a bit more, I found that the key is in the slightly changed 
logic in ata_do_reset().  Previously, devices were changed from class 
ATA_DEV_UNKNOWN to ATA_DEV_NONE only if one device was found to be !UNKNOWN, but 
now the change is systematic.  Since my SATA disk is by itself on the port, this 
makes it become ATA_DEV_NONE where previously it was left as ATA_DEV_UNKNOWN 
when ata_do_reset() returned.

Changing this makes the system bootable again.

Cheers,
Marc