From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [2.6 patch] select ATA_SFF Date: Wed, 23 Apr 2008 11:16:53 +0900 Message-ID: <480E9C15.6080103@gmail.com> References: <20080421213147.GH2633@cs181133002.pp.htv.fi> <480DE3C4.5@ru.mvista.com> <480DE6F5.8060403@gmail.com> <480DE9E8.2070809@ru.mvista.com> <480DEB1F.5060500@gmail.com> <480DF7B7.9030000@rtr.ca> <480DF876.7070800@gmail.com> <480DF9BD.1080104@rtr.ca> <480DFE76.8000809@ru.mvista.com> <480E345D.9090406@ru.mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from po-out-1718.google.com ([72.14.252.155]:43504 "EHLO po-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753732AbYDWCSn (ORCPT ); Tue, 22 Apr 2008 22:18:43 -0400 Received: by po-out-1718.google.com with SMTP id y22so152500pof.1 for ; Tue, 22 Apr 2008 19:17:21 -0700 (PDT) In-Reply-To: <480E345D.9090406@ru.mvista.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Sergei Shtylyov Cc: Mark Lord , Jeff Garzik , Adrian Bunk , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Alan Cox Sergei Shtylyov wrote: > Hello, I wrote: > >>> I suppose. If we were needlessly pedantic, then perhaps >>> the libata-bmdma.c should be renamed to libata-sff.c, > > It *was* renamed to libata-sff.c, back in 2006. :-) > >>> and the libata-sff.c should be renamed libata-tf.c > > Not before splitting SFF-8038i stuff from it. > >>> But there's probably been a document or two since then, >>> where the SFF folks have documented the TF interfaces, too. > >> Don't know, at least I haven't encountered such spec. Unless you >> mean SFF-8020i (ATAPI CD-ROM spec). > > I've looked thru the list of their spec. and it didn't seem to have > any about taskfile specifically. SFF-8070 (ATAPI CD-RW) refers to > ATA/PI-4 for that matter. Aik... We can do s/sff/tf/ and leave bmdma alone to avoid even more confusion but sff has meant tf base interface for quite some time now in libata and I think it'll be better to remember that sff is the new tf. Sorry about the mess. Thanks. -- tejun