Re: [PATCH] libata-eh copy result_tf flags from outgoing tf

[Tejun Heo <htejun@gmail.com>]

Mark Lord wrote:
>> Those flags are to tell which parts of the TF are valid or should be 
>> read in case of TFLAG_LBA48.  So, a TF after tf_read should always 
>> have TFLAG_ISADDR and TFLAG_DEVICE.  TFLAG_LBA48 works both ways.  If 
>> it was set when tf_read is called the higher part of LBA is read and 
>> the resulting tf should have TFLAG_LBA48 set.  But yeah the original 
>> code isn't like that.  If you can fix it up together with the NCQ 
>> path, it would be great.
> ..
> 
> No, I'm not going to touch the mainline path.  tf_read is used to read
> the taskfile, but it doesn't always contain an LBA address, so I'm not so
> sure that forcing TFLAG_ISADDR is always correct.
> 
> And since I don't know that code as well as you, I don't want to end up
> having to help debug something that might break as a result.
> 
> This may warrant two patches.. one to fix the NCQ bug (already posted),
> and perhaps another from you or Jeff if you want to change the behaviour.

Alright, fair enough.

-- 
tejun