From: Jeff Garzik <jeff@garzik.org>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: linux-ide <linux-ide@vger.kernel.org>
Subject: Re: libata: functions with definition should not be extern
Date: Fri, 25 Apr 2008 00:47:11 -0400 [thread overview]
Message-ID: <4811624F.8040405@garzik.org> (raw)
In-Reply-To: <1209087454.20088.11.camel@brick>
Harvey Harrison wrote:
> Noticed by sparse
> drivers/ata/libata-core.c:3380:12: warning: function 'ata_wait_after_reset' with external linkage has definition
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> drivers/ata/libata-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index b0b00af..fe5c88b 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -3377,7 +3377,7 @@ int ata_wait_ready(struct ata_link *link, unsigned long deadline,
> * RETURNS:
> * 0 if @linke is ready before @deadline; otherwise, -errno.
> */
> -extern int ata_wait_after_reset(struct ata_link *link, unsigned long deadline,
> +int ata_wait_after_reset(struct ata_link *link, unsigned long deadline,
> int (*check_ready)(struct ata_link *link))
> {
applied
prev parent reply other threads:[~2008-04-25 4:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-25 1:37 libata: functions with definition should not be extern Harvey Harrison
2008-04-25 4:47 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4811624F.8040405@garzik.org \
--to=jeff@garzik.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).