* libata: functions with definition should not be extern
@ 2008-04-25 1:37 Harvey Harrison
2008-04-25 4:47 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2008-04-25 1:37 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-ide
Noticed by sparse
drivers/ata/libata-core.c:3380:12: warning: function 'ata_wait_after_reset' with external linkage has definition
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
drivers/ata/libata-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index b0b00af..fe5c88b 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -3377,7 +3377,7 @@ int ata_wait_ready(struct ata_link *link, unsigned long deadline,
* RETURNS:
* 0 if @linke is ready before @deadline; otherwise, -errno.
*/
-extern int ata_wait_after_reset(struct ata_link *link, unsigned long deadline,
+int ata_wait_after_reset(struct ata_link *link, unsigned long deadline,
int (*check_ready)(struct ata_link *link))
{
msleep(ATA_WAIT_AFTER_RESET_MSECS);
--
1.5.5.1.270.g89765
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: libata: functions with definition should not be extern
2008-04-25 1:37 libata: functions with definition should not be extern Harvey Harrison
@ 2008-04-25 4:47 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-04-25 4:47 UTC (permalink / raw)
To: Harvey Harrison; +Cc: linux-ide
Harvey Harrison wrote:
> Noticed by sparse
> drivers/ata/libata-core.c:3380:12: warning: function 'ata_wait_after_reset' with external linkage has definition
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> drivers/ata/libata-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index b0b00af..fe5c88b 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -3377,7 +3377,7 @@ int ata_wait_ready(struct ata_link *link, unsigned long deadline,
> * RETURNS:
> * 0 if @linke is ready before @deadline; otherwise, -errno.
> */
> -extern int ata_wait_after_reset(struct ata_link *link, unsigned long deadline,
> +int ata_wait_after_reset(struct ata_link *link, unsigned long deadline,
> int (*check_ready)(struct ata_link *link))
> {
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-25 4:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-25 1:37 libata: functions with definition should not be extern Harvey Harrison
2008-04-25 4:47 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).