linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: Tejun Heo <htejun@gmail.com>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] libata-acpi.c: remove unneeded #if's
Date: Fri, 25 Apr 2008 00:48:20 -0400	[thread overview]
Message-ID: <48116294.80106@garzik.org> (raw)
In-Reply-To: <20080421225035.GK2633@cs181133002.pp.htv.fi>

Adrian Bunk wrote:
> These #if's are unneeded since they:
> - did anyway not handle the CONFIG_ACPI_DOCK_MODULE case correctly and
> - this is already handled in include/acpi/acpi_drivers.h and
> - it's now correctly handled in kconfig.
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> Acked-by: Tejun Heo <htejun@gmail.com>
> 
> ---
> 
> This patch has been sent on:
> - 14 Apr 2008
> - 31 Mar 2008
> 
>  drivers/ata/libata-acpi.c |    4 ----
>  1 file changed, 4 deletions(-)
> 
> 2a7326b50cd80e6570803d4efb7bc15e029e61e3 diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
> index bf98a56..1db912e 100644
> --- a/drivers/ata/libata-acpi.c
> +++ b/drivers/ata/libata-acpi.c
> @@ -227,11 +227,9 @@ void ata_acpi_associate(struct ata_host *host)
>  			acpi_install_notify_handler(ap->acpi_handle,
>  						    ACPI_SYSTEM_NOTIFY,
>  						    ata_acpi_ap_notify, ap);
> -#if defined(CONFIG_ACPI_DOCK) || defined(CONFIG_ACPI_DOCK_MODULE)
>  			/* we might be on a docking station */
>  			register_hotplug_dock_device(ap->acpi_handle,
>  						     ata_acpi_ap_notify, ap);
> -#endif
>  		}
>  
>  		for (j = 0; j < ata_link_max_devices(&ap->link); j++) {
> @@ -241,11 +239,9 @@ void ata_acpi_associate(struct ata_host *host)
>  				acpi_install_notify_handler(dev->acpi_handle,
>  						ACPI_SYSTEM_NOTIFY,
>  						ata_acpi_dev_notify, dev);
> -#if defined(CONFIG_ACPI_DOCK) || defined(CONFIG_ACPI_DOCK_MODULE)
>  				/* we might be on a docking station */
>  				register_hotplug_dock_device(dev->acpi_handle,
>  						ata_acpi_dev_notify, dev);
> -#endif

applied



  reply	other threads:[~2008-04-25  4:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-21 22:50 [2.6 patch] libata-acpi.c: remove unneeded #if's Adrian Bunk
2008-04-25  4:48 ` Jeff Garzik [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-04-14 18:40 Adrian Bunk
2008-04-15  2:07 ` Tejun Heo
2008-03-30 23:05 Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48116294.80106@garzik.org \
    --to=jeff@garzik.org \
    --cc=bunk@kernel.org \
    --cc=htejun@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).