From: Jeff Garzik <jgarzik@pobox.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: Mark Lord <mlord@pobox.com>, Jeff Garzik <jgarzik@redhat.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] make sata_print_link_status() static
Date: Fri, 25 Apr 2008 00:48:29 -0400 [thread overview]
Message-ID: <4811629D.3040601@pobox.com> (raw)
In-Reply-To: <20080421085111.GB26897@cs181133002.pp.htv.fi>
Adrian Bunk wrote:
> sata_print_link_status() can now become static.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
>
> drivers/ata/libata-core.c | 3 +--
> include/linux/libata.h | 1 -
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> 017dd9ea17af28a805e099c245ae1f8991eb6b5a diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 1686773..4b918d7 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -2605,7 +2605,7 @@ void ata_port_probe(struct ata_port *ap)
> * LOCKING:
> * None.
> */
> -void sata_print_link_status(struct ata_link *link)
> +static void sata_print_link_status(struct ata_link *link)
> {
> u32 sstatus, scontrol, tmp;
>
> @@ -6197,7 +6197,6 @@ EXPORT_SYMBOL_GPL(ata_host_detach);
> EXPORT_SYMBOL_GPL(ata_sg_init);
> EXPORT_SYMBOL_GPL(ata_qc_complete);
> EXPORT_SYMBOL_GPL(ata_qc_complete_multiple);
> -EXPORT_SYMBOL_GPL(sata_print_link_status);
> EXPORT_SYMBOL_GPL(atapi_cmd_type);
> EXPORT_SYMBOL_GPL(ata_tf_to_fis);
> EXPORT_SYMBOL_GPL(ata_tf_from_fis);
> diff --git a/include/linux/libata.h b/include/linux/libata.h
> index 2d8874b..84618df 100644
> --- a/include/linux/libata.h
> +++ b/include/linux/libata.h
> @@ -847,7 +847,6 @@ static inline int ata_port_is_dummy(struct ata_port *ap)
> return ap->ops == &ata_dummy_port_ops;
> }
>
> -extern void sata_print_link_status(struct ata_link *link);
> extern void ata_port_probe(struct ata_port *);
> extern int sata_set_spd(struct ata_link *link);
> extern int ata_std_prereset(struct ata_link *link, unsigned long deadline);
applied
prev parent reply other threads:[~2008-04-25 4:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-21 8:51 [2.6 patch] make sata_print_link_status() static Adrian Bunk
2008-04-25 4:48 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4811629D.3040601@pobox.com \
--to=jgarzik@pobox.com \
--cc=bunk@kernel.org \
--cc=jgarzik@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlord@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).