From: Jeff Garzik <jeff@garzik.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: Tejun Heo <htejun@gmail.com>, Jeff Garzik <jgarzik@redhat.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] make sata_set_spd_needed() static
Date: Fri, 25 Apr 2008 00:48:36 -0400 [thread overview]
Message-ID: <481162A4.50500@garzik.org> (raw)
In-Reply-To: <20080421085117.GC26897@cs181133002.pp.htv.fi>
Adrian Bunk wrote:
> sata_set_spd_needed() can now become static.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
>
> drivers/ata/libata-core.c | 2 +-
> drivers/ata/libata.h | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> bb4bcf58edb56a5fc9d7401046adcafcffff46a6 diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 4b918d7..8c2bb65 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -2761,7 +2761,7 @@ static int __sata_set_spd_needed(struct ata_link *link, u32 *scontrol)
> * RETURNS:
> * 1 if SATA spd configuration is needed, 0 otherwise.
> */
> -int sata_set_spd_needed(struct ata_link *link)
> +static int sata_set_spd_needed(struct ata_link *link)
> {
> u32 scontrol;
>
> diff --git a/drivers/ata/libata.h b/drivers/ata/libata.h
> index 4aeeabb..ae2cfd9 100644
> --- a/drivers/ata/libata.h
> +++ b/drivers/ata/libata.h
> @@ -101,7 +101,6 @@ extern int ata_dev_revalidate(struct ata_device *dev, unsigned int new_class,
> unsigned int readid_flags);
> extern int ata_dev_configure(struct ata_device *dev);
> extern int sata_down_spd_limit(struct ata_link *link);
> -extern int sata_set_spd_needed(struct ata_link *link);
> extern int ata_down_xfermask_limit(struct ata_device *dev, unsigned int sel);
> extern void ata_sg_clean(struct ata_queued_cmd *qc);
> extern void ata_qc_free(struct ata_queued_cmd *qc);
applied
prev parent reply other threads:[~2008-04-25 4:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-21 8:51 [2.6 patch] make sata_set_spd_needed() static Adrian Bunk
2008-04-21 8:57 ` Jeff Garzik
2008-04-21 9:03 ` Adrian Bunk
2008-04-25 4:48 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481162A4.50500@garzik.org \
--to=jeff@garzik.org \
--cc=bunk@kernel.org \
--cc=htejun@gmail.com \
--cc=jgarzik@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).