[2.6 patch] make sata_set_spd_needed() static

[2.6 patch] make sata_set_spd_needed() static

[Adrian Bunk]

sata_set_spd_needed() can now become static.

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

 drivers/ata/libata-core.c |    2 +-
 drivers/ata/libata.h      |    1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

bb4bcf58edb56a5fc9d7401046adcafcffff46a6 diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 4b918d7..8c2bb65 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -2761,7 +2761,7 @@ static int __sata_set_spd_needed(struct ata_link *link, u32 *scontrol)
  *	RETURNS:
  *	1 if SATA spd configuration is needed, 0 otherwise.
  */
-int sata_set_spd_needed(struct ata_link *link)
+static int sata_set_spd_needed(struct ata_link *link)
 {
 	u32 scontrol;
 
diff --git a/drivers/ata/libata.h b/drivers/ata/libata.h
index 4aeeabb..ae2cfd9 100644
--- a/drivers/ata/libata.h
+++ b/drivers/ata/libata.h
@@ -101,7 +101,6 @@ extern int ata_dev_revalidate(struct ata_device *dev, unsigned int new_class,
 			      unsigned int readid_flags);
 extern int ata_dev_configure(struct ata_device *dev);
 extern int sata_down_spd_limit(struct ata_link *link);
-extern int sata_set_spd_needed(struct ata_link *link);
 extern int ata_down_xfermask_limit(struct ata_device *dev, unsigned int sel);
 extern void ata_sg_clean(struct ata_queued_cmd *qc);
 extern void ata_qc_free(struct ata_queued_cmd *qc);

Re: [2.6 patch] make sata_set_spd_needed() static

[Jeff Garzik]

On Mon, Apr 21, 2008 at 11:51:17AM +0300, Adrian Bunk wrote:
> sata_set_spd_needed() can now become static.
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>

For future reference...  please don't email jgarzik@redhat.com unless
its an NDA issue or similar.  That email is only for signed-off-by
lines, never for actual email (you never see me post to a list
@redhat.com, nor will you see me in git as /author/ @redhat.com)

After leaving MandrakeSoft for Red Hat several years ago, I found it
wise to point everybody to a generic email (jgarzik@pobox.com) rather
than an email address ultimately out of my control.

Anyway, a humble request from me to you,

	Jeff

Re: [2.6 patch] make sata_set_spd_needed() static

[Adrian Bunk]

On Mon, Apr 21, 2008 at 04:57:32AM -0400, Jeff Garzik wrote:
> On Mon, Apr 21, 2008 at 11:51:17AM +0300, Adrian Bunk wrote:
> > sata_set_spd_needed() can now become static.
> > 
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> 
> For future reference...  please don't email jgarzik@redhat.com unless
> its an NDA issue or similar.  That email is only for signed-off-by
> lines, never for actual email (you never see me post to a list
> @redhat.com, nor will you see me in git as /author/ @redhat.com)
>...

In this case I pasted it from a signed-off-by line...

I will try to remember this special case of your email address in the 
future (but please don't be offended if I might send accidentally to 
the @redhat.com address again).

> 	Jeff

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [2.6 patch] make sata_set_spd_needed() static

[Jeff Garzik]

Adrian Bunk wrote:
> sata_set_spd_needed() can now become static.
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> 
> ---
> 
>  drivers/ata/libata-core.c |    2 +-
>  drivers/ata/libata.h      |    1 -
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> bb4bcf58edb56a5fc9d7401046adcafcffff46a6 diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 4b918d7..8c2bb65 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -2761,7 +2761,7 @@ static int __sata_set_spd_needed(struct ata_link *link, u32 *scontrol)
>   *	RETURNS:
>   *	1 if SATA spd configuration is needed, 0 otherwise.
>   */
> -int sata_set_spd_needed(struct ata_link *link)
> +static int sata_set_spd_needed(struct ata_link *link)
>  {
>  	u32 scontrol;
>  
> diff --git a/drivers/ata/libata.h b/drivers/ata/libata.h
> index 4aeeabb..ae2cfd9 100644
> --- a/drivers/ata/libata.h
> +++ b/drivers/ata/libata.h
> @@ -101,7 +101,6 @@ extern int ata_dev_revalidate(struct ata_device *dev, unsigned int new_class,
>  			      unsigned int readid_flags);
>  extern int ata_dev_configure(struct ata_device *dev);
>  extern int sata_down_spd_limit(struct ata_link *link);
> -extern int sata_set_spd_needed(struct ata_link *link);
>  extern int ata_down_xfermask_limit(struct ata_device *dev, unsigned int sel);
>  extern void ata_sg_clean(struct ata_queued_cmd *qc);
>  extern void ata_qc_free(struct ata_queued_cmd *qc);

applied