From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-mips@linux-mips.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] Au1200: kill IDE driver function prototypes
Date: Mon, 28 Apr 2008 22:36:35 +0400 [thread overview]
Message-ID: <48161933.5020200@ru.mvista.com> (raw)
In-Reply-To: <200804282046.53474.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
>>>Fix these warnings emitted when compiling drivers/ide/mips/au1xxx-ide.c:
>>>include/asm/mach-au1x00/au1xxx_ide.h:137: warning: 'auide_tune_drive' declared
>>>`static' but never defined
>>>include/asm/mach-au1x00/au1xxx_ide.h:138: warning: 'auide_tune_chipset' declared
>>> `static' but never defined
>>>by wiping out the whole "function prototyping" section from the header file
>>><asm-mips/mach-au1x00/au1xxx_ide.h> as it mostly declared functions that are
>>>already dead in the IDE driver; move the only useful prototype into the driver.
>>>Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>>>---
>>>I'm not sure thru which tree this should go -- probably thru Linux/MIPS one...
>>>Bart, au1xxx-ide-fix-mwdma-support.patch will probably need to be updated to
>>>remove that added prototype since it won't be needed anymore...
>> Which you haven't done either in that patch or in
>>au1xxx-ide-use-init_dma-method.patch. So, face the consequences:
>>drivers/ide/mips/au1xxx-ide.c:456: error: conflicting types for 'auide_ddma_init'
>>drivers/ide/mips/au1xxx-ide.c:51: error: previous declaration of
>>'auide_ddma_init' was here
>>drivers/ide/mips/au1xxx-ide.c:456: error: conflicting types for 'auide_ddma_init'
>>drivers/ide/mips/au1xxx-ide.c:51: error: previous declaration of
>>'auide_ddma_init' was here
>>drivers/ide/mips/au1xxx-ide.c:51: warning: 'auide_ddma_init' used but never
>>defined
> Sorry for that, I remember taking a look at au1xxx-ide-fix-mwdma-support.patch
> and it was OK
This patch was a fitting place to get rid of that proto since it removed
the sole call because of which that proto was needed.
> (now I see that it was au1xxx-ide-use-init_dma-method.patch that
> needed an update). I'll fix it in today's update.
TIA.
> Thanks,
> Bart
MBR, Sergei
prev parent reply other threads:[~2008-04-28 18:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-14 18:28 [PATCH] Au1200: kill IDE driver function prototypes Sergei Shtylyov
2008-04-15 20:54 ` Bartlomiej Zolnierkiewicz
2008-04-28 14:26 ` Sergei Shtylyov
2008-04-28 18:46 ` Bartlomiej Zolnierkiewicz
2008-04-28 18:36 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48161933.5020200@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).