Re: [PATCH] sata_mv Improve naming of main_irq cause/mask identifiers

[Jeff Garzik <jgarzik@pobox.com>]

Mark Lord wrote:
> Jeff Garzik wrote:
> ..
>> applied patches 1-8...
> ..
>>> -    irq_stat = readl(hpriv->main_cause_reg_addr);
>>> -    irq_mask = readl(hpriv->main_mask_reg_addr);
> ..
>>> +    main_cause = readl(hpriv->main_cause_reg_addr);
>>> +    main_mask  = readl(hpriv->main_mask_reg_addr);
> ..
>>  ...but I am sad to see this.  irq_stat and irq_mask naming make the 
>> driver more accessible to outsiders, because the purpose of the 
>> registers is immediately apparent even without having the docs at hand 
>> -- which is the case for everybody in the world except me and you :)
>>
>> I applied the patch anyway because you are defacto maintainer of sata_mv.
>>
>> However, I _request_ a reconsideration of some of these renames when 
>> viewed in that light.  It's your prerogative as maintainer to ignore 
>> or honor that request as you see fit...  We all have to balance making 
>> our own job easier with making the driver accessible to outsiders, 
>> particularly those without NDA'd docs.
> ..
> 
> Here ya go:
> 
> -------------------- SNIP ----------------------------------
> 
> Tidy up naming of things associated with the PCI / SOC chip
> "main irq cause/mask" registers, as inspired by Jeff.
> 
> Signed-off-by: Mark Lord <mlord@pobox.com>

applied