* [PATCH] pata_via: Fix 6410 misdetect
@ 2008-04-29 13:10 Alan Cox
2008-04-29 21:43 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Alan Cox @ 2008-04-29 13:10 UTC (permalink / raw)
To: akpm, jeff, linux-ide
The discrete VIA ATA chips don't have 0x40 enable bits. We check that
properly in one location but not another. This causes some users 6410
RAID cards to be incorrectly skipped.
Would be good if this made the next kernel (may also be appropriate for
stable)
Signed-off-by: Alan Cox <alan@redhat.com>
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.25-mm1/drivers/ata/pata_via.c linux-2.6.25-mm1/drivers/ata/pata_via.c
--- linux.vanilla-2.6.25-mm1/drivers/ata/pata_via.c 2008-04-28 11:36:48.000000000 +0100
+++ linux-2.6.25-mm1/drivers/ata/pata_via.c 2008-04-29 10:16:07.000000000 +0100
@@ -464,11 +464,12 @@
}
pci_dev_put(isa);
- /* 0x40 low bits indicate enabled channels */
- pci_read_config_byte(pdev, 0x40 , &enable);
- enable &= 3;
- if (enable == 0) {
- return -ENODEV;
+ if (!(config->flags & VIA_NO_ENABLES)) {
+ /* 0x40 low bits indicate enabled channels */
+ pci_read_config_byte(pdev, 0x40 , &enable);
+ enable &= 3;
+ if (enable == 0)
+ return -ENODEV;
}
/* Initialise the FIFO for the enabled channels. */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] pata_via: Fix 6410 misdetect
2008-04-29 13:10 [PATCH] pata_via: Fix 6410 misdetect Alan Cox
@ 2008-04-29 21:43 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-04-29 21:43 UTC (permalink / raw)
To: Alan Cox; +Cc: akpm, linux-ide
Alan Cox wrote:
> The discrete VIA ATA chips don't have 0x40 enable bits. We check that
> properly in one location but not another. This causes some users 6410
> RAID cards to be incorrectly skipped.
>
> Would be good if this made the next kernel (may also be appropriate for
> stable)
>
> Signed-off-by: Alan Cox <alan@redhat.com>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-29 21:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-29 13:10 [PATCH] pata_via: Fix 6410 misdetect Alan Cox
2008-04-29 21:43 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).