From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: libata-eh/pmp command sequence on NCQ media error Date: Thu, 01 May 2008 11:55:52 +0900 Message-ID: <48193138.2070306@gmail.com> References: <480F9D29.4070603@rtr.ca> <480FF229.2060808@rtr.ca> <481168FA.5020709@pobox.com> <4811E2FB.4040100@rtr.ca> <48120269.8020101@gmail.com> <4818E5B2.1040801@rtr.ca> <4818E73D.9070201@rtr.ca> <48191422.30409@gmail.com> <48192ED5.9030402@rtr.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from wf-out-1314.google.com ([209.85.200.171]:26873 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754629AbYEACz6 (ORCPT ); Wed, 30 Apr 2008 22:55:58 -0400 Received: by wf-out-1314.google.com with SMTP id 28so661678wfc.4 for ; Wed, 30 Apr 2008 19:55:57 -0700 (PDT) In-Reply-To: <48192ED5.9030402@rtr.ca> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Mark Lord Cc: Jeff Garzik , IDE/ATA development list Mark Lord wrote: > Tejun Heo wrote: >> Mark Lord wrote: >>>> So why are we taking a hammer to things there? >> >> Hmmm... The reset action might be too heavy handed but maybe keeping >> that categorized as ATA bus error is still a good idea so that >> multiple errors w/ that bit set can trigger speed down. >> >>> FWIW, this patch fixes it for me (and fixes a misleading printk). >>> Or I could just clear that bit from sata_mv before invoking EH. >>> (??) >> >> Does the bit get set for the host link or pmp fanout links? > .. > > It's only on the pmp fanout link. Dunno why it gets set, but it does. Which PMP are you using? I've never seen something like that. If it's on fan-out port, you'll want to implement a quirk in libata-pmp.c as it will probably happen with other controllers too. Thanks. -- tejun