Re: libata-eh/pmp command sequence on NCQ media error

[Mark Lord <liml@rtr.ca>]

Tejun Heo wrote:
> Mark Lord wrote:
>> Tejun Heo wrote:
>>> Mark Lord wrote:
>>>>> So why are we taking a hammer to things there?
>>>
>>> Hmmm... The reset action might be too heavy handed but maybe keeping 
>>> that categorized as ATA bus error is still a good idea so that 
>>> multiple errors w/ that bit set can trigger speed down.
>>>
>>>> FWIW, this patch fixes it for me (and fixes a misleading printk).
>>>> Or I could just clear that bit from sata_mv before invoking EH.
>>>> (??)
>>>
>>> Does the bit get set for the host link or pmp fanout links?
>> ..
>>
>> It's only on the pmp fanout link. Dunno why it gets set, but it does.
> 
> Which PMP are you using?  I've never seen something like that.  If it's 
> on fan-out port, you'll want to implement a quirk in libata-pmp.c as it 
> will probably happen with other controllers too.
..

Mmmm.. good point.  I'm seeing it with the Marvell PM right now.
If I remember, I'll try it with the Silicon Image PM on Thursday.

Bedtime here.

cheers!