From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] libata: Add Intel SCH PATA Support Date: Tue, 06 May 2008 08:04:57 -0400 Message-ID: <48204969.3080301@pobox.com> References: <20080505172356.636649e6@dxy.sh.intel.com> <481EE284.2010708@ru.mvista.com> <20080505224420.44730838@dxy.sh.intel.com> <481F2144.5000409@ru.mvista.com> <20080506094131.4bd70c8a@dxy.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:59805 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752959AbYEFMFN (ORCPT ); Tue, 6 May 2008 08:05:13 -0400 In-Reply-To: <20080506094131.4bd70c8a@dxy.sh.intel.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Alek Du Cc: Sergei Shtylyov , Bartlomiej Zolnierkiewicz , Alan Cox , linux-ide@vger.kernel.org Alek Du wrote: > Hi Sergei and All, > > I modified the driver again according to comments from Sergei, please help to review it. > > >>>From 9a318d7ff2fc55811374b5b959524f5afcb8d5a6 Mon Sep 17 00:00:00 2001 > From: Alek Du > Date: Mon, 5 May 2008 14:32:04 +0800 > Subject: [PATCH] libata: Add Intel SCH PATA Support > > This patch adds Intel SCH chipsets (AF82US15W, AF82US15L, AF82UL11L) PATA controller > support. > > Signed-off-by: Alek Du > --- > drivers/ata/Kconfig | 9 ++ > drivers/ata/Makefile | 1 + > drivers/ata/pata_sch.c | 244 ++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 254 insertions(+), 0 deletions(-) > create mode 100644 drivers/ata/pata_sch.c overall, looks good. your suspend/resume routines are copies of the in-kernel ata_pci_device_suspend/resume, and should be removed (just refer directly to the generic functions) agree w/ Alan and Sergei's comments, too Jeff