From: Jeff Garzik <jgarzik@pobox.com>
To: Alek Du <alek.du@intel.com>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: Add Intel SCH PATA Support
Date: Tue, 06 May 2008 08:09:11 -0400 [thread overview]
Message-ID: <48204A67.7070308@pobox.com> (raw)
In-Reply-To: <20080506094131.4bd70c8a@dxy.sh.intel.com>
Also...
Alek Du wrote:
> +/*
> + * Supports:
> + * Intel SCH (AF82US15W, AF82US15L, AF82UL11L) chipsets
> + */
a link to the public datasheet would be nice, somewhere in a comment
> +static const struct pci_device_id sch_pci_tbl[] = {
> + /* Intel SCH PATA Controller */
> + { 0x8086, 0x811A, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
recommend using PCI_VDEVICE() macro
[and it would be nice if someone converted ata_piix.c, too]
> + { } /* terminate list */
> +static int __init sch_init(void)
> +{
> + int rc;
> +
> + rc = pci_register_driver(&sch_pci_driver);
> + if (rc)
> + return rc;
> + in_module_init = 0;
> + return 0;
> +}
with the in_module_init thing removed (per Alan's comment), this can
become 'return pci_register_driver(...)' nicely
next prev parent reply other threads:[~2008-05-06 12:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080505172356.636649e6@dxy.sh.intel.com>
2008-05-05 10:33 ` [PATCH] libata: Add Intel SCH PATA Support Sergei Shtylyov
[not found] ` <20080505224420.44730838@dxy.sh.intel.com>
2008-05-05 15:01 ` Sergei Shtylyov
2008-05-06 1:41 ` Alek Du
2008-05-06 11:44 ` Alan Cox
2008-05-06 11:50 ` Sergei Shtylyov
2008-05-06 12:04 ` Jeff Garzik
2008-05-06 12:09 ` Jeff Garzik [this message]
2008-05-06 13:31 ` again: " Alek Du
2008-05-06 14:18 ` Jeff Garzik
2008-05-06 16:20 ` Bartlomiej Zolnierkiewicz
2008-05-06 15:59 ` Alan Cox
2008-05-07 2:14 ` Alek Du
2008-05-07 17:38 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48204A67.7070308@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=alek.du@intel.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).