From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>, ryan.roth@ch2m.com
Subject: Re: [PATCH #upstream-fixes] ata_piix: verify SIDPR access before enabling it
Date: Tue, 06 May 2008 10:17:40 -0400 [thread overview]
Message-ID: <48206884.6020205@garzik.org> (raw)
In-Reply-To: <481916CC.3070504@gmail.com>
Tejun Heo wrote:
> On certain configurations (certain macbooks), even though all the
> conditions for SIDPR access described in the datasheet are met,
> actually reading those registers just returns 0 and have no effect on
> write. Verify SIDPR is actually working before enabling it.
>
> This is reported by Ryan Roth in bz#10512.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Ryan Roth <ryan.roth@ch2m.com>
> ---
> Apple did another weird thing with ich8m in addition to the weird
> lockup on second port enable and SIDPR causes drive misdetection.
> This one probably should go to -stable too.
>
> Thanks.
>
> drivers/ata/ata_piix.c | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
applied
prev parent reply other threads:[~2008-05-06 14:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-01 1:03 [PATCH #upstream-fixes] ata_piix: verify SIDPR access before enabling it Tejun Heo
2008-05-06 14:17 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48206884.6020205@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=ryan.roth@ch2m.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).