linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Bland <rbland@combinedeffort.com>
To: jgarzik@pobox.com
Cc: linux-ide@vger.kernel.org
Subject: HPA Problem in libata-core.c?
Date: Fri, 16 May 2008 19:26:01 +0100	[thread overview]
Message-ID: <482DD1B9.6040408@combinedeffort.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

Hi Jeff,

Apologies if I'm way off-base here, but I was having problems unlocking 
a HPA and took a look at the above.

It seemed the code was bailing before it unlocked the HPA, but would 
appreciate your feedback.

Cheers,

Rich

[-- Attachment #2: libata-core.patch --]
[-- Type: text/x-patch, Size: 585 bytes --]

--- libata-core.c~	2008-05-16 19:22:04.000000000 +0100
+++ libata-core.c	2008-05-16 19:08:42.000000000 +0100
@@ -1243,13 +1243,14 @@
 				"HPA detected: current %llu, native %llu\n",
 				(unsigned long long)sectors,
 				(unsigned long long)native_sectors);
-		else if (native_sectors < sectors)
+		else if (native_sectors < sectors) {
 			ata_dev_printk(dev, KERN_WARNING,
 				"native sectors (%llu) is smaller than "
 				"sectors (%llu)\n",
 				(unsigned long long)native_sectors,
 				(unsigned long long)sectors);
-		return 0;
+			return 0;
+		}
 	}
 
 	/* let's unlock HPA */

                 reply	other threads:[~2008-05-16 18:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=482DD1B9.6040408@combinedeffort.com \
    --to=rbland@combinedeffort.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).