linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* HPA Problem in libata-core.c?
@ 2008-05-16 18:26 Richard Bland
  0 siblings, 0 replies; only message in thread
From: Richard Bland @ 2008-05-16 18:26 UTC (permalink / raw)
  To: jgarzik; +Cc: linux-ide

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

Hi Jeff,

Apologies if I'm way off-base here, but I was having problems unlocking 
a HPA and took a look at the above.

It seemed the code was bailing before it unlocked the HPA, but would 
appreciate your feedback.

Cheers,

Rich

[-- Attachment #2: libata-core.patch --]
[-- Type: text/x-patch, Size: 585 bytes --]

--- libata-core.c~	2008-05-16 19:22:04.000000000 +0100
+++ libata-core.c	2008-05-16 19:08:42.000000000 +0100
@@ -1243,13 +1243,14 @@
 				"HPA detected: current %llu, native %llu\n",
 				(unsigned long long)sectors,
 				(unsigned long long)native_sectors);
-		else if (native_sectors < sectors)
+		else if (native_sectors < sectors) {
 			ata_dev_printk(dev, KERN_WARNING,
 				"native sectors (%llu) is smaller than "
 				"sectors (%llu)\n",
 				(unsigned long long)native_sectors,
 				(unsigned long long)sectors);
-		return 0;
+			return 0;
+		}
 	}
 
 	/* let's unlock HPA */

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-05-16 18:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-16 18:26 HPA Problem in libata-core.c? Richard Bland

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).