From: Jeff Garzik <jgarzik@pobox.com>
To: Mark Lord <liml@rtr.ca>
Cc: Tejun Heo <htejun@gmail.com>, Alan Cox <alan@redhat.com>,
IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 10/10] sata_mv: ensure empty request queue for FBS-NCQ EH
Date: Mon, 19 May 2008 17:41:41 -0400 [thread overview]
Message-ID: <4831F415.4080604@pobox.com> (raw)
In-Reply-To: <48317A24.4080003@rtr.ca>
Mark Lord wrote:
> Check for an empty request queue before stopping EDMA after a FBS-NCQ
> error,
> as per recommendation from the Marvell datasheet.
>
> This ensures that the EDMA won't suddenly become active again
> just after our subsequent check of the empty/idle bits.
>
> Also bump DRV_VERSION.
>
> Signed-off-by: Mark Lord <mlord@pobox.com>
> ---
>
> Is DRV_VERSION even useful now?
> I could do another patch to just nuke it.
It is standard practice to export all driver versions via dmesg and
modinfo for all libata drivers, so I would prefer that it stay, for
consistency.
Is it useful?
That depends on the maintainer's definition and upkeep of the version
number. If you never update it, of course its useless. If you update
it when the driver achieves certain milestones, i.e. "2.0" when all your
changes are complete, then it may be relevant to you and your userbase.
Version numbers tend to be quite handy because drivers get backported
all over the place, so you might not be able to assume that sata_mv
version 1.21 implies kernel version 2.6.26, for example.
Jeff
next prev parent reply other threads:[~2008-05-19 21:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 13:18 [PATCH 01/04] sata_mv always do softreset Mark Lord
2008-05-14 13:19 ` [PATCH 02/04] sata_mv fis irq register fixes Mark Lord
2008-05-14 13:21 ` [PATCH 03/04] sata_mv group genIIe flags Mark Lord
2008-05-14 13:24 ` [PATCH 04/04] sata_mv async notify for genIIe only Mark Lord
2008-05-17 17:34 ` [PATCH 05/09] sata_mv don't blindly enable IRQs Mark Lord
2008-05-17 17:35 ` [PATCH 06/09] sata_mv consolidate main_irq_mask updates Mark Lord
2008-05-17 17:36 ` [PATCH 07/09] sata_mv fix pmp drives not found Mark Lord
2008-05-17 17:37 ` [PATCH 08/09] sata_mv disregard masked irqs Mark Lord
2008-05-17 17:38 ` [PATCH 09/09] sata_mv cache main_irq_mask register in hpriv Mark Lord
2008-05-19 13:01 ` [PATCH 10/10] sata_mv: ensure empty request queue for FBS-NCQ EH Mark Lord
2008-05-19 21:41 ` Jeff Garzik [this message]
2008-05-19 21:42 ` Jeff Garzik
2008-05-19 18:27 ` [PATCH 09/09] sata_mv cache main_irq_mask register in hpriv Grant Grundler
2008-05-17 17:41 ` [PATCH 05/09] sata_mv don't blindly enable IRQs Jeff Garzik
2008-05-17 17:45 ` Mark Lord
2008-05-17 17:49 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4831F415.4080604@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@redhat.com \
--cc=htejun@gmail.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).