linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 2.6.26-rc2 1/3] sata_promise: fix irq clearing buglets
Date: Mon, 19 May 2008 17:43:36 -0400	[thread overview]
Message-ID: <4831F488.9070802@garzik.org> (raw)
In-Reply-To: <200805171647.m4HGlZFW015961@harpo.it.uu.se>

Mikael Pettersson wrote:
> This patch fixes two bugs in sata_promise's irq status clearing paths:
> 1. When clearing the irq status for a specific port, the driver
>    read the global SEQMASK register. This is wrong because that
>    clears the irq status for _all_ ports.
> 2. pdc_thaw() incorrectly added the PDC_INT_SEQMASK host register
>    offset to a per-port ata engine base address. This resulted in
>    it reading the unrelated PDC_PKT_SUBMIT register, which did not
>    have the desired irq status clearing effect.
> 
> In both cases the fix is to read from the port's Command/Status
> register. This also matches what Promise's own driver does.
> 
> Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
> ---
>  drivers/ata/sata_promise.c |    7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

is sata_sx4 similarly affected?



  parent reply	other threads:[~2008-05-19 21:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-17 16:47 [PATCH 2.6.26-rc2 1/3] sata_promise: fix irq clearing buglets Mikael Pettersson
2008-05-19 21:42 ` Jeff Garzik
2008-05-19 21:43 ` Jeff Garzik [this message]
2008-05-20  8:48   ` Mikael Pettersson
2008-05-20 21:15     ` Jeff Garzik
2008-05-21  8:23       ` Mikael Pettersson
2008-05-22  8:29       ` Mikael Pettersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4831F488.9070802@garzik.org \
    --to=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=mikpe@it.uu.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).