* [PATCH #upstream-fixes] libata: SRST can't be trusted on PMP sil3726
@ 2008-05-21 5:11 Tejun Heo
2008-05-29 1:59 ` Tejun Heo
2008-05-30 22:11 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Tejun Heo @ 2008-05-21 5:11 UTC (permalink / raw)
To: Jeff Garzik, IDE/ATA development list
As in sil4726, SRST can't be trusted on sil3726 causing detection
problems under certain configuraitons. I thought it was from the
Config Disk device but apparently not.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
drivers/ata/libata-pmp.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/libata-pmp.c b/drivers/ata/libata-pmp.c
index 3374ec5..b65db30 100644
--- a/drivers/ata/libata-pmp.c
+++ b/drivers/ata/libata-pmp.c
@@ -322,9 +322,12 @@ static void sata_pmp_quirks(struct ata_port *ap)
if (vendor == 0x1095 && devid == 0x3726) {
/* sil3726 quirks */
ata_port_for_each_link(link, ap) {
- /* class code report is unreliable */
+ /* Class code report is unreliable and SRST
+ * times out under certain configurations.
+ */
if (link->pmp < 5)
- link->flags |= ATA_LFLAG_ASSUME_ATA;
+ link->flags |= ATA_LFLAG_NO_SRST |
+ ATA_LFLAG_ASSUME_ATA;
/* port 5 is for SEMB device and it doesn't like SRST */
if (link->pmp == 5)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH #upstream-fixes] libata: SRST can't be trusted on PMP sil3726
2008-05-21 5:11 [PATCH #upstream-fixes] libata: SRST can't be trusted on PMP sil3726 Tejun Heo
@ 2008-05-29 1:59 ` Tejun Heo
2008-05-30 22:11 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2008-05-29 1:59 UTC (permalink / raw)
To: Jeff Garzik, IDE/ATA development list
Tejun Heo wrote:
> As in sil4726, SRST can't be trusted on sil3726 causing detection
> problems under certain configuraitons. I thought it was from the
> Config Disk device but apparently not.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
Ping.
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH #upstream-fixes] libata: SRST can't be trusted on PMP sil3726
2008-05-21 5:11 [PATCH #upstream-fixes] libata: SRST can't be trusted on PMP sil3726 Tejun Heo
2008-05-29 1:59 ` Tejun Heo
@ 2008-05-30 22:11 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2008-05-30 22:11 UTC (permalink / raw)
To: Tejun Heo; +Cc: IDE/ATA development list
Tejun Heo wrote:
> As in sil4726, SRST can't be trusted on sil3726 causing detection
> problems under certain configuraitons. I thought it was from the
> Config Disk device but apparently not.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> drivers/ata/libata-pmp.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-05-30 22:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-21 5:11 [PATCH #upstream-fixes] libata: SRST can't be trusted on PMP sil3726 Tejun Heo
2008-05-29 1:59 ` Tejun Heo
2008-05-30 22:11 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).