From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 04/22] ide: add ide_deprecated_find_port() helper Date: Wed, 21 May 2008 18:29:56 +0400 Message-ID: <483431E4.7020307@ru.mvista.com> References: <20080116232556.9166.13457.sendpatchset@localhost.localdomain> <20080116232624.9166.73929.sendpatchset@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from h155.mvista.com ([63.81.120.155]:10396 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1755429AbYEUOaT (ORCPT ); Wed, 21 May 2008 10:30:19 -0400 In-Reply-To: <20080116232624.9166.73929.sendpatchset@localhost.localdomain> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Hello. Bartlomiej Zolnierkiewicz wrote: > * Factor out code for finding ide_hwifs[] slot from ide_register_hw() > to ide_deprecated_find_port(). > * Convert bast-ide, ide-cs and delkin_cb host drivers to use ide_device_add() > instead of ide_register_hw() (while at it drop doing "ide_unregister()" loop > which tries to unregister _all_ IDE interfaces if useable ide_hwifs[] slot > cannot be find). Er... this patch didn't actually drop that loop (late remark :-). > This patch leaves us with only two ide_register_hw() users: > - drivers/macintosh/mediabay.c > - drivers/ide/ide.c I wonder whether ide_register_hw() was much good at all since it didn't actually permit to register chips using MMIO: you couldn't pass that info via 'hw' and it set 'hwif->noprobe' to 0, thus giving you no chance to skip probing which wouldn't work anyway; for the same reason it was no good for DMA capable chips since you had not time to install ide_dma_check() and other DMA methods. Am I right here? MBR, Sergei