linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: MATSUBAYASHI 'Shaolin' Kohji <shaolin@rhythmaning.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: ata_piix on MacBook4,1: fail to startup in a certain situation
Date: Thu, 29 May 2008 18:10:18 +0900	[thread overview]
Message-ID: <483E72FA.60901@gmail.com> (raw)
In-Reply-To: <20080529084351.191F529C0D5@m02-blue.in.shared-server.net>

MATSUBAYASHI 'Shaolin' Kohji wrote:
> At Thu, 29 May 2008 15:09:13 +0900,
> Tejun Heo wrote:
>> So, it shouldn't get here.  Strange.  Ah... Crap.  Now I see it.
>> Generic entry for 2828 is above ich8m_apple_sata entry.  I wonder how
>> this ever worked.  Here's the updated patch.  This is without the SIDPR
>> change.  If this doesn't work please remove PIIX_FLAG_SIDPR from
>> ich8m_apple_sata entry and see whether that helps.
> 
> Thanks. Now I see why it did get to that line even with the patch...
> 
> Anyway, I confirmed that your newest patch (plus PIIX_FLAG_SIDPR removal)
> now works fine both with the AC adapter plugged or unplugged.
> So the final patch for this case should be as follows.

Just to confirm, it doesn't work w/ PIIX_FLAG_SIDPR?

-- 
tejun

  reply	other threads:[~2008-05-29  9:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080528075106.F2C3D29C127@m02-blue.in.shared-server.net>
     [not found] ` <20080528075747.A18A5114160@m03-blue.in.shared-server.net>
     [not found]   ` <483D1429.3080804@gmail.com>
2008-05-28  9:21     ` ata_piix on MacBook4,1: fail to startup in a certain situation MATSUBAYASHI 'Shaolin' Kohji
2008-05-28 14:23       ` Tejun Heo
2008-05-28 22:53         ` MATSUBAYASHI 'Shaolin' Kohji
2008-05-29  0:23           ` Tejun Heo
2008-05-29  1:12             ` MATSUBAYASHI 'Shaolin' Kohji
2008-05-29  1:45               ` Tejun Heo
2008-05-29  3:41                 ` MATSUBAYASHI 'Shaolin' Kohji
2008-05-29  6:09                   ` Tejun Heo
2008-05-29  8:43                     ` MATSUBAYASHI 'Shaolin' Kohji
2008-05-29  9:10                       ` Tejun Heo [this message]
2008-05-29  9:59                         ` MATSUBAYASHI 'Shaolin' Kohji
2008-05-29 12:56                           ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=483E72FA.60901@gmail.com \
    --to=htejun@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=shaolin@rhythmaning.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).