From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: ata_piix on MacBook4,1: fail to startup in a certain situation Date: Thu, 29 May 2008 18:10:18 +0900 Message-ID: <483E72FA.60901@gmail.com> References: <20080528075106.F2C3D29C127@m02-blue.in.shared-server.net> <20080528075747.A18A5114160@m03-blue.in.shared-server.net> <483D1429.3080804@gmail.com> <20080528092117.4A5177080E8@m04-blue.in.shared-server.net> <483D6AF4.8000502@gmail.com> <20080528225338.5FB121E0868@m06-blue.in.shared-server.net> <483DF782.1050208@gmail.com> <20080529011256.60F8ECC0F2@m01-blue.in.shared-server.net> <483E0AAE.9000307@gmail.com> <20080529034139.A766529C0D5@m02-blue.in.shared-server.net> <483E4889.1070501@gmail.com> <20080529084351.191F529C0D5@m02-blue.in.shared-server.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from wf-out-1314.google.com ([209.85.200.168]:35824 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752581AbYE2JKZ (ORCPT ); Thu, 29 May 2008 05:10:25 -0400 Received: by wf-out-1314.google.com with SMTP id 27so2897590wfd.4 for ; Thu, 29 May 2008 02:10:24 -0700 (PDT) In-Reply-To: <20080529084351.191F529C0D5@m02-blue.in.shared-server.net> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: MATSUBAYASHI 'Shaolin' Kohji Cc: linux-ide@vger.kernel.org MATSUBAYASHI 'Shaolin' Kohji wrote: > At Thu, 29 May 2008 15:09:13 +0900, > Tejun Heo wrote: >> So, it shouldn't get here. Strange. Ah... Crap. Now I see it. >> Generic entry for 2828 is above ich8m_apple_sata entry. I wonder how >> this ever worked. Here's the updated patch. This is without the SIDPR >> change. If this doesn't work please remove PIIX_FLAG_SIDPR from >> ich8m_apple_sata entry and see whether that helps. > > Thanks. Now I see why it did get to that line even with the patch... > > Anyway, I confirmed that your newest patch (plus PIIX_FLAG_SIDPR removal) > now works fine both with the AC adapter plugged or unplugged. > So the final patch for this case should be as follows. Just to confirm, it doesn't work w/ PIIX_FLAG_SIDPR? -- tejun