linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Kristen Carlson Accardi <kristen.c.accardi@intel.com>,
	Theodore Tso <tytso@mit.edu>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: ahci: power off unused ports
Date: Sun, 01 Jun 2008 15:16:56 -0400	[thread overview]
Message-ID: <4842F5A8.9020708@garzik.org> (raw)
In-Reply-To: <20080531080015.GG5405@ucw.cz>

Pavel Machek wrote:
> Hi!
> 
>>>> As far as I know the patch has gone nowhere.  I believe that 
>>>> Jeff wanted something more flexible than the module parameter that
>>>> I provided to override the BIOS options.  I am not working on this,
>>>> I figured he had a pretty firm idea what he wanted so he was better
>>>> equipped to write the patch.
>>> Thanks Kristen,
>>>
>>> Can you say which laptops you had tested this on where it saved power?
>>> (Did you test any Thinkpads, in particular?)  I'm wondering if it's
>>> worth trying to forward port your patch as a private mod to my kernel;
>>> 30 to 40 minutes of extra battery life is nothing to sneeze at!
>>>
>>> 						- Ted
>>>
>> I tested this on an Intel mobile software development platform 
>> with a newer mobile ICH - the power savings were measured at the actual 
>> component (via probes on the ICH), so I did not measure the power 
>> savings at the wall socket, although I would expect the power savings
>> to be even greater on the other side of the power supply.  So in short,
>> yes, I think it's worth it to give it a try - the patch is pretty
>> unintrusive, so it should be that difficult a port to do.
> 
> Can you repost the patch? I believe we should push it and only add
> complex enable/disable functionality if someone needs it...

If you are talking about SATA -- incorrect.

The patch deals with policy, and the user MUST have the ability to 
control this stuff.  Otherwise you create a situation where the user 
might be denied hotplug use in valid cases, or similar negative situations.

	Jeff




  reply	other threads:[~2008-06-01 19:17 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-08 23:10 [PATCH] ata: ahci: power off unused ports Kristen Carlson Accardi
2008-05-08 23:37 ` Matthew Garrett
2008-05-08 23:35   ` Kristen Carlson Accardi
2008-05-09  0:14     ` Matthew Garrett
2008-05-09  0:28       ` Kristen Carlson Accardi
2008-05-09 15:58   ` Lennart Sorensen
2008-05-09 16:06     ` Matthew Garrett
2008-05-09 16:14       ` Lennart Sorensen
2008-05-09 17:14         ` Kristen Carlson Accardi
2008-05-09 15:06 ` Mark Lord
2008-05-09 15:28   ` Port control interface (was Re: [PATCH] ata: ahci: power off unused ports) Jeff Garzik
2008-05-27  3:08 ` [PATCH] ata: ahci: power off unused ports Theodore Tso
2008-05-27 21:32   ` Kristen Carlson Accardi
2008-05-27 22:59     ` Theodore Tso
2008-05-27 23:32       ` Kristen Carlson Accardi
2008-05-31  8:00         ` Pavel Machek
2008-06-01 19:16           ` Jeff Garzik [this message]
2008-06-02  7:04             ` Alan Cox
2008-06-02  7:43               ` Jeff Garzik
2008-06-02  8:22                 ` Alan Cox
2008-06-02  9:48                   ` Jeff Garzik
2008-06-02 13:54                     ` Alan Cox
2008-06-02 16:55                     ` Kristen Carlson Accardi
2008-06-02 13:03                 ` Mark Lord
2008-06-02 16:07                   ` Jeff Garzik
2008-06-02 17:00                     ` Kristen Carlson Accardi
2008-06-02 17:45                       ` Jeff Garzik
2008-06-02 17:47                         ` Kristen Carlson Accardi
2008-06-02 18:15                           ` Jeff Garzik
2008-06-02 18:16                             ` Kristen Carlson Accardi
2008-06-02 18:30                               ` Ric Wheeler
2008-06-02 18:40                                 ` Jeff Garzik
2008-06-02 18:49                                   ` Ric Wheeler
2008-06-02 18:52                                     ` Jeff Garzik
2008-06-02 20:00                                   ` Matthew Garrett
2008-06-02 18:38                               ` Jeff Garzik
2008-06-03 16:49                                 ` Kristen Carlson Accardi
2008-06-02 17:07                     ` Greg Freemyer
2008-06-02 16:57                   ` Kristen Carlson Accardi
2008-06-02 17:44                     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4842F5A8.9020708@garzik.org \
    --to=jeff@garzik.org \
    --cc=kristen.c.accardi@intel.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).