From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] ata: ahci: power off unused ports Date: Mon, 02 Jun 2008 03:43:35 -0400 Message-ID: <4843A4A7.3020809@garzik.org> References: <20080508161008.59361de5@appleyard> <20080527030854.GC7515@mit.edu> <20080527143202.4bab5bf0@appleyard> <20080527225926.GE6843@mit.edu> <20080527163251.04054a74@appleyard> <20080531080015.GG5405@ucw.cz> <4842F5A8.9020708@garzik.org> <20080602080440.25fc663c@core> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:47126 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751193AbYFBHnt (ORCPT ); Mon, 2 Jun 2008 03:43:49 -0400 In-Reply-To: <20080602080440.25fc663c@core> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Alan Cox Cc: Pavel Machek , Kristen Carlson Accardi , Theodore Tso , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Alan Cox wrote: >> If you are talking about SATA -- incorrect. >> >> The patch deals with policy, and the user MUST have the ability to >> control this stuff. Otherwise you create a situation where the user >> might be denied hotplug use in valid cases, or similar negative situations. > > The policy isn't however complicated. Tejun added the stuff for forcing > cable type and mode on setup and has therefore written all the per device > setup code we might need. Alternatively a single > > foo=1/0 > > option has been fine for acpi and will do fine for this. Total additional > cost - 1 line. The key requirement is per-port control. Ideally via hdparm or another userspace tool, but kernel command line (module options) or sysfs would be just fine too. And agreed, the minimal you need is simply 1/0 for the port's policy. Jeff