From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 1/1] ipr: Fix HDIO_GET_IDENTITY oops for SATA devices Date: Mon, 02 Jun 2008 12:08:14 -0400 Message-ID: <48441AEE.6050605@garzik.org> References: <12124164141515-patch-mail.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <12124164141515-patch-mail.ibm.com> Sender: linux-scsi-owner@vger.kernel.org To: Brian King Cc: James.Bottomley@HansenPartnership.com, linux-scsi@vger.kernel.org, thlin@linux.vnet.ibm.com, linux-ide@vger.kernel.org, miltonm@bga.com List-Id: linux-ide@vger.kernel.org Brian King wrote: > Currently, ipr does not support HDIO_GET_IDENTITY to SATA devices. > An oops occurs if userspace attempts to send the command. Since hald > issues the command, ensure we fail the ioctl in ipr. This is a > temporary solution to the oops. Once the ipr libata EH conversion > is upstream, ipr will fully support HDIO_GET_IDENTITY. > > Tested-by: Milton Miller > Signed-off-by: Brian King > --- > > linux-2.6-bjking1/drivers/scsi/ipr.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) I was pretty happy with the rough draft of your EH conversion... where does that stand now? Jeff