From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] libata: Handle bay devices in dock stations Date: Tue, 03 Jun 2008 14:54:54 -0400 Message-ID: <4845937E.7040902@garzik.org> References: <20080528143857.GB5585@homac.suse.de> <4845886E.2010505@garzik.org> <20080603182759.GB3556@homac> <20080603182908.GA5596@srcf.ucam.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:44375 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751048AbYFCSy5 (ORCPT ); Tue, 3 Jun 2008 14:54:57 -0400 In-Reply-To: <20080603182908.GA5596@srcf.ucam.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Matthew Garrett Cc: linux-kernel@vger.kernel.org, Tejun Heo , linux-ide@vger.kernel.org, linux-acpi@vger.kernel.org, akpm@linux-foundation.org Matthew Garrett wrote: > On Tue, Jun 03, 2008 at 08:27:59PM +0200, Holger Macht wrote: >> * Differentiate between bay devices in dock stations and others: >> >> - When an ACPI_NOTIFY_EJECT_REQUEST appears, just signal uevent to >> userspace (that is when the optional eject button on a bay device is >> pressed/pulled) giving the possibility to unmount file systems and to >> clean up. Also, only send uevent in case we get an EJECT_REQUEST >> without doing anything else. In other cases, you'll get an add/remove >> event because libata attaches/detaches the device. >> >> - In case of a dock event, which in turn signals an >> ACPI_NOTIFY_EJECT_REQUEST, immediately detach the device, because it >> may already have been gone >> >> * In case of an ACPI_NOTIFY_DEVICE/BUS_CHECK, evaluate _STA to check if >> the device has been plugged or unplugged. If plugged, hotplug it, if >> unplugged, just signal event to userspace >> (initial patch by Matthew Garrett ) >> >> * Call ACPI _EJ0 for detached devices >> >> Signed-off-by: Holger Macht > > Acked-by: Matthew Garrett thanks, both!