From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [patch 10/50] libata: force hardreset if link is in powersave mode Date: Fri, 06 Jun 2008 23:14:10 -0400 Message-ID: <4849FD02.9000901@garzik.org> References: <20080607010215.358296706@sous-sol.org> <20080607010555.470605116@sous-sol.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:51080 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752272AbYFGDOY (ORCPT ); Fri, 6 Jun 2008 23:14:24 -0400 In-Reply-To: Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Linus Torvalds Cc: Chris Wright , linux-kernel@vger.kernel.org, stable@kernel.org, IDE/ATA development list , Justin Forbes , Zwane Mwaikambo , Theodore Ts'o , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , Chuck Ebbert , Domenico Andreoli , akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Tejun Heo , matthieu.castet@parrot.com, Greg Kroah-Hartman Linus Torvalds wrote: > > On Fri, 6 Jun 2008, Chris Wright wrote: >> -stable review patch. If anyone has any objections, please let us know. >> --------------------- >> >> From: Tejun Heo >> >> Inhibiting link PM mode doesn't bring the link back online if it's >> already in powersave mode. If SRST is used in these cases, libata EH >> thinks that the link is offline and fails detection. Force hardreset >> if link is in powersave mode. > > This isn't upstream. Maybe there's some reason it's not needed upstream, > but it would be nice to know. We do hard reset by default... Jeff