linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: "MATSUBAYASHI, 'Shaolin' Kohji" <shaolin@rhythmaning.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: ata_piix on MacBook4,1: CD/DVD drive often fails to work
Date: Mon, 09 Jun 2008 22:46:32 +0900	[thread overview]
Message-ID: <484D3438.5030306@gmail.com> (raw)
In-Reply-To: <k6d4mqwy5z.wl%shaolin@rhythmaning.org>

Hello,

MATSUBAYASHI, 'Shaolin' Kohji wrote:
> Sorry all, it was just my fault - this patch did not improve the
> stability. It just happened that annoying "status error" message
> did not appeared for a while. Now the message appears again every
> two seconds until I have to remove ide-cd_mod kernel module.
> 
> --
> Kohji
> 
> At Mon, 09 Jun 2008 20:16:28 +0900,
> MATSUBAYASHI, 'Shaolin' Kohji wrote:
>> Then the following patch fixed the problem anyhow at least on my machine
>> (I suspect changing from ich_pata_100 to ich_pata_66, especially
>> removing the flag PIIX_FLAG_CHECKINTR, did something good in this case).
>>
>> I am not certain whether this patch is the right/correct solution
>> for that, but anyway here's it. Let me know if there's something
>> I can do for debugging further.
>>
>> --
>> Kohji
>>
>> [2 ata_piix-pata-apple.patch <text/plain; US-ASCII (7bit)>]
>> diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
>> index 81b7ae3..93b5741 100644
>> --- a/drivers/ata/ata_piix.c
>> +++ b/drivers/ata/ata_piix.c
>> @@ -214,6 +214,8 @@ static const struct pci_device_id piix_pci_tbl[] = {
>>  	/* ICH7/7-R (i945, i975) UDMA 100*/
>>  	{ 0x8086, 0x27DF, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich_pata_100 },
>>  	{ 0x8086, 0x269E, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich_pata_100 },
>> +	/* ICH8 Mobile PATA Controller, Apple */
>> +	{ 0x8086, 0x2850, 0x106b, 0x00a1, 0, 0, ich_pata_66 },
>>  	/* ICH8 Mobile PATA Controller */
>>  	{ 0x8086, 0x2850, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich_pata_100 },

You're using IDE piix driver so modifying ata_piix won't help you much.
 Can you please give a shot at ata_piix?

-- 
tejun

      reply	other threads:[~2008-06-09 13:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-09 11:16 ata_piix on MacBook4,1: CD/DVD drive often fails to work MATSUBAYASHI, 'Shaolin' Kohji
2008-06-09 13:11 ` MATSUBAYASHI, 'Shaolin' Kohji
2008-06-09 13:46   ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=484D3438.5030306@gmail.com \
    --to=htejun@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=shaolin@rhythmaning.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).