* CDC_PLAY_AUDIO check in cdrom_count_tracks() and other oddities
@ 2008-06-12 3:51 Tejun Heo
2008-06-12 18:47 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2008-06-12 3:51 UTC (permalink / raw)
To: Jens Axboe, IDE/ATA development list, Linux Kernel
Hello, Jens.
I'm tracking down a bug where HAL doesn't mount media automatically.
It turned out that CDROM_DISC_STATUS wasn't reporting correct disc
type which was caused by CDC_PLAY_AUDIO check failure at the top of
cdrom_count_tracks().
I've went through MMC-3 but couldn't find anything which associates
play audio capability with READ_TOC. READ_TOC was mandatory command,
so according to MMC-3, there's no reason to avoid issuing READ_TOC on
!CDC_PLAY_AUDIO. Is there something I don't know?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: CDC_PLAY_AUDIO check in cdrom_count_tracks() and other oddities
2008-06-12 3:51 CDC_PLAY_AUDIO check in cdrom_count_tracks() and other oddities Tejun Heo
@ 2008-06-12 18:47 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2008-06-12 18:47 UTC (permalink / raw)
To: Tejun Heo; +Cc: IDE/ATA development list, Linux Kernel
On Thu, Jun 12 2008, Tejun Heo wrote:
> Hello, Jens.
>
> I'm tracking down a bug where HAL doesn't mount media automatically.
> It turned out that CDROM_DISC_STATUS wasn't reporting correct disc
> type which was caused by CDC_PLAY_AUDIO check failure at the top of
> cdrom_count_tracks().
>
> I've went through MMC-3 but couldn't find anything which associates
> play audio capability with READ_TOC. READ_TOC was mandatory command,
> so according to MMC-3, there's no reason to avoid issuing READ_TOC on
> !CDC_PLAY_AUDIO. Is there something I don't know?
That check predates me :-)
I can't imagine drives NOT having READ_TOC, so I don't think it's a
problem to remove the depedency on CDC_PLAY_AUDIO.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-06-12 18:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-12 3:51 CDC_PLAY_AUDIO check in cdrom_count_tracks() and other oddities Tejun Heo
2008-06-12 18:47 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).