Re: sata_mv on Orion: mv_err_intr when shutting down

[Tejun Heo <htejun@gmail.com>]

Mark Lord wrote:
> Mmm.. I suppose .remove() is not supposed to be called, then.
> What does happen, is sd_shutdown() runs ("Stopping disk"),
> and that's that.
> 
> Weird.  I'd have thought there'd be a call somewhere to .port_stop()
> or even .host_stop() on shutdown, but I don't see one anywhere.
> 
> Tejun?
> Don't we try and turn off the hardware (IRQs) after stopping the drives?
> Because these guys are seeing interrupts afterwards (loss of PHY, it
> seems),
> and that looks somewhat risky -- such an interrupt might kill the
> shutdown sequence,
> leaving a machine in limbo.  Or not (?).

We don't call port or host stop during shutdown.  We only do so when the
controller goes away or the module is being unloaded.  All that happens
is spinning down the disks via sd_shutdown().  I don't think drivers are
supposed to put everything into quiesced state when shutting down.  The
system can remain in working state except for ones which require special
care.

The interesting thing here is that sata_mv can see the disk going off
the power, which is kind of cool.  The controller and CPU are watching
itself as it goes off the life support and is drifting awaaaaaayyyy.

The PSU has switched off and power to the drive was cut.  I don't think
anything can go wrong at that point.

Thanks.

-- 
tejun