From: Mark Lord <liml@rtr.ca>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
Tejun Heo <htejun@gmail.com>
Subject: [PATCH] sata_mv: safer logic for limit_warnings
Date: Wed, 18 Jun 2008 21:57:42 -0400 [thread overview]
Message-ID: <4859BD16.4020600@rtr.ca> (raw)
In-Reply-To: <4859340E.60203@rtr.ca>
There is a miniscule chance that two separate host controllers
might be in sata_mv at the same time and manage to decrement
the static limit_warnings variable below zero.
Fix the comparison to deal with it.
Signed-off-by: Mark Lord <mlord@pobox.com>
---
(blush) How did I miss that ???
--- old/drivers/ata/sata_mv.c 2008-06-17 19:22:15.000000000 -0400
+++ linux//drivers/ata/sata_mv.c 2008-06-18 21:52:19.000000000 -0400
@@ -1607,7 +1607,7 @@
* Much of the time, this could just work regardless.
* So for now, just log the incident, and allow the attempt.
*/
- if (limit_warnings && (qc->nbytes / qc->sect_size) > 1) {
+ if (limit_warnings > 0 && (qc->nbytes / qc->sect_size) > 1) {
--limit_warnings;
ata_link_printk(qc->dev->link, KERN_WARNING, DRV_NAME
": attempting PIO w/multiple DRQ: "
next prev parent reply other threads:[~2008-06-19 1:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-18 16:11 [PATCH 01/02] sata_mv: enable async_notify for 60x1 Rev.C0 and higher Mark Lord
2008-06-18 16:13 ` [PATCH 02/02] sata_mv: warn on PIO with multiple DRQs Mark Lord
2008-06-19 0:29 ` Jeff Garzik
2008-06-19 1:44 ` Mark Lord
2008-06-19 1:48 ` Tejun Heo
2008-06-19 1:56 ` Jeff Garzik
2008-06-19 2:00 ` Mark Lord
2008-06-19 6:28 ` Jeff Garzik
2008-06-19 20:23 ` Mark Lord
2008-06-19 1:57 ` Mark Lord [this message]
2008-07-04 13:11 ` [PATCH] sata_mv: safer logic for limit_warnings Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4859BD16.4020600@rtr.ca \
--to=liml@rtr.ca \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).