From: Mark Lord <liml@rtr.ca>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
Tejun Heo <htejun@gmail.com>
Subject: Re: [PATCH 02/02] sata_mv: warn on PIO with multiple DRQs
Date: Wed, 18 Jun 2008 22:00:29 -0400 [thread overview]
Message-ID: <4859BDBD.8000007@rtr.ca> (raw)
In-Reply-To: <4859BCE8.4060408@pobox.com>
Jeff Garzik wrote:
> Mark Lord wrote:
>> Just about everything can do some form of DMA nowadays,
>> but regardless of that the sata_mv chipsets have errata
>> for PIO of anything more than a single sector.
>>
>> In practice, I haven't managed to trigger the issue here,
>> but the errata descriptions indicate that it should be a major
>> issue for any volume of multi-sector PIO commands.
>
>
> I need to review the state of PIO-multi, but IIRC it's not used by default.
>
> We should be able to handle this errata without banning all PIO...
..
I'm not really all that worried about it.
But it affects *non multi* PIO as well -- anything that can generate
more than a single DRQ per command-issue.
So a READ_SECTORS or WRITE_SECTORS (pio) for anything more than
a single sector could do it, in theory.
If we *really* care, then I'll dig into it deeper in the next kernel.
It can be worked around in the IRQ handler, by taking great care in
the exact sequence of IRQ-arrival and DRQ-status checks.
Heck.. we might even have it right (by accident) today.
Cheers
next prev parent reply other threads:[~2008-06-19 2:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-18 16:11 [PATCH 01/02] sata_mv: enable async_notify for 60x1 Rev.C0 and higher Mark Lord
2008-06-18 16:13 ` [PATCH 02/02] sata_mv: warn on PIO with multiple DRQs Mark Lord
2008-06-19 0:29 ` Jeff Garzik
2008-06-19 1:44 ` Mark Lord
2008-06-19 1:48 ` Tejun Heo
2008-06-19 1:56 ` Jeff Garzik
2008-06-19 2:00 ` Mark Lord [this message]
2008-06-19 6:28 ` Jeff Garzik
2008-06-19 20:23 ` Mark Lord
2008-06-19 1:57 ` [PATCH] sata_mv: safer logic for limit_warnings Mark Lord
2008-07-04 13:11 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4859BDBD.8000007@rtr.ca \
--to=liml@rtr.ca \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).