[PATCH] pci: VT3336 can't do MSI either

[PATCH] pci: VT3336 can't do MSI either

[Tejun Heo]

It seems VT3336 can't do msi either as with its bro 3351.  Disable it.
Reported in the following SUSE bug.

  https://bugzilla.novell.com/show_bug.cgi?id=300001

Signed-off-by: Tejun Heo <tj@kernel.org>
---
Anyone interested in queuing this for -rc8?  Thanks.

 drivers/pci/quirks.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index dabb563..9d95f0b 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -1685,6 +1685,7 @@ static void __init quirk_disable_all_msi(struct pci_dev *dev)
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_GCNB_LE, quirk_disable_all_msi);
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RS400_200, quirk_disable_all_msi);
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RS480, quirk_disable_all_msi);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VT3336, quirk_disable_all_msi);
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VT3351, quirk_disable_all_msi);
 
 /* Disable MSI on chipsets that are known to not support it */

Re: [PATCH] pci: VT3336 can't do MSI either

[Andrew Morton]

On Tue, 24 Jun 2008 14:35:14 +0900 Tejun Heo <tj@kernel.org> wrote:

> It seems VT3336 can't do msi either as with its bro 3351.  Disable it.
> Reported in the following SUSE bug.
> 
>   https://bugzilla.novell.com/show_bug.cgi?id=300001
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>

(argh.  Is that permanent(ish)?)

> ---
> Anyone interested in queuing this for -rc8?  Thanks.

Strictly a Jesse thing I guess, but I can do it ujnless there be objections.

> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index dabb563..9d95f0b 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -1685,6 +1685,7 @@ static void __init quirk_disable_all_msi(struct pci_dev *dev)
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_GCNB_LE, quirk_disable_all_msi);
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RS400_200, quirk_disable_all_msi);
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RS480, quirk_disable_all_msi);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VT3336, quirk_disable_all_msi);
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VT3351, quirk_disable_all_msi);
>  
>  /* Disable MSI on chipsets that are known to not support it */

Re: [PATCH] pci: VT3336 can't do MSI either

[Tejun Heo]

Andrew Morton wrote:
> On Tue, 24 Jun 2008 14:35:14 +0900 Tejun Heo <tj@kernel.org> wrote:
> 
>> It seems VT3336 can't do msi either as with its bro 3351.  Disable it.
>> Reported in the following SUSE bug.
>>
>>   https://bugzilla.novell.com/show_bug.cgi?id=300001
>>
>> Signed-off-by: Tejun Heo <tj@kernel.org>
> 
> (argh.  Is that permanent(ish)?)

I believe the link will stay for some time to come and the information
there isn't critical anyway.  The only controller which can do MSI on
the board is ahci and the situation is just the same as the other via
chip.  I just didn't want to lose the mail address of the reporter and
wasn't too sure whether he/she would want to be cc'd on public mailing list.

If you were talking about the email address, I've had quite a few
problems with my gmail account lately including being kicked out of all
the mailing lists regularly, so yeah I think I'm gonna use @kernel.org
from now on.

Thanks.

-- 
tejun

Re: [PATCH] pci: VT3336 can't do MSI either

[Jesse Barnes]

On Monday, June 23, 2008 10:53 pm Andrew Morton wrote:
> On Tue, 24 Jun 2008 14:35:14 +0900 Tejun Heo <tj@kernel.org> wrote:
> > It seems VT3336 can't do msi either as with its bro 3351.  Disable it.
> > Reported in the following SUSE bug.
> >
> >   https://bugzilla.novell.com/show_bug.cgi?id=300001
> >
> > Signed-off-by: Tejun Heo <tj@kernel.org>
>
> (argh.  Is that permanent(ish)?)
>
> > ---
> > Anyone interested in queuing this for -rc8?  Thanks.
>
> Strictly a Jesse thing I guess, but I can do it ujnless there be
> objections.

Yeah, no objections here.  Thanks.

Jesse