From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] libata support for rotation speed Date: Fri, 27 Jun 2008 02:56:41 -0400 Message-ID: <48648F29.8040806@garzik.org> References: <20080619160216.GH4392@parisc-linux.org> <20080619175904.GK4392@parisc-linux.org> <1213899895.3501.45.camel@localhost.localdomain> <20080619183113.GM4392@parisc-linux.org> <485AAD0D.9000205@garzik.org> <20080619191337.GO4392@parisc-linux.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:54738 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759931AbYF0G4r (ORCPT ); Fri, 27 Jun 2008 02:56:47 -0400 In-Reply-To: <20080619191337.GO4392@parisc-linux.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Matthew Wilcox Cc: James Bottomley , linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org Matthew Wilcox wrote: > On Thu, Jun 19, 2008 at 03:01:33PM -0400, Jeff Garzik wrote: >> Matthew Wilcox wrote: >>> On Thu, Jun 19, 2008 at 01:24:55PM -0500, James Bottomley wrote: >>>> This looks like it can be called for ATA_DEV_ATAPI as well, in which >>>> case it's an illegal page to ask for. >>> I was under the impression that this entire file is only used for >>> non-atapi devices. >> Correct. That code path is not travelled by ATAPI. > > Thanks, Jeff. Here's version three, including the form factor from word > 168: > > > Add support for VPD page b1 to libata > > SCSI VPD page b1 reports the nominal rotation speed and physical size > of the device. Devices that conform to ATA-8 can return this information > in words 217 and 168 of the identify data. > > Signed-off-by: Matthew Wilcox applied (2.6.27)