From: Tejun Heo <tj@kernel.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jeff Garzik <jeff@garzik.org>,
IDE/ATA development list <linux-ide@vger.kernel.org>,
Travis Read <ics@dark.net.au>
Subject: Re: [PATCH #upstream-fixes] sata_sil24: add DIDs for adaptec flavors
Date: Wed, 02 Jul 2008 17:47:48 +0900 [thread overview]
Message-ID: <486B40B4.30708@kernel.org> (raw)
In-Reply-To: <20080702085517.61909c74@lxorguk.ukuu.org.uk>
Alan Cox wrote:
> On Wed, 02 Jul 2008 11:52:09 +0900
> Tejun Heo <tj@kernel.org> wrote:
>
>> Adaptec uses different DIDs for 3132. Add them.
>>
>> Reported by Travis Read.
>>
>> Signed-off-by: Tejun Heo <tj@kernel.org>
>> Cc: Travis Read <ics@dark.net.au>
>
> NAK
>
>> { PCI_VDEVICE(CMD, 0x0242), BID_SIL3132 },
>> { PCI_VDEVICE(CMD, 0x3131), BID_SIL3131 },
>> { PCI_VDEVICE(CMD, 0x3531), BID_SIL3131 },
>> + { PCI_VDEVICE(CMD, 0x0242), BID_SIL3132 },
>> + { PCI_VDEVICE(CMD, 0x0244), BID_SIL3132 },
>
> The first of those is a duplicate (see the top entry)
Heh.. yeah. What was I thinking. Thanks for spotting it.
--
tejun
next prev parent reply other threads:[~2008-07-02 8:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-02 2:52 [PATCH #upstream-fixes] sata_sil24: add DIDs for adaptec flavors Tejun Heo
2008-07-02 7:55 ` Alan Cox
2008-07-02 8:47 ` Tejun Heo [this message]
2008-07-02 8:50 ` [PATCH #upstream-fixes take#2] sata_sil24: add DID for another adaptec falvor Tejun Heo
2008-07-04 13:10 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486B40B4.30708@kernel.org \
--to=tj@kernel.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ics@dark.net.au \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).