* [PATCH #upstream-fixes] sata_sil24: add DIDs for adaptec flavors
@ 2008-07-02 2:52 Tejun Heo
2008-07-02 7:55 ` Alan Cox
0 siblings, 1 reply; 5+ messages in thread
From: Tejun Heo @ 2008-07-02 2:52 UTC (permalink / raw)
To: Jeff Garzik, IDE/ATA development list, Travis Read
Adaptec uses different DIDs for 3132. Add them.
Reported by Travis Read.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Travis Read <ics@dark.net.au>
---
drivers/ata/sata_sil24.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c
index 8ee6b5b..5633a31 100644
--- a/drivers/ata/sata_sil24.c
+++ b/drivers/ata/sata_sil24.c
@@ -372,6 +372,8 @@ static const struct pci_device_id sil24_pci_tbl[] = {
{ PCI_VDEVICE(CMD, 0x0242), BID_SIL3132 },
{ PCI_VDEVICE(CMD, 0x3131), BID_SIL3131 },
{ PCI_VDEVICE(CMD, 0x3531), BID_SIL3131 },
+ { PCI_VDEVICE(CMD, 0x0242), BID_SIL3132 },
+ { PCI_VDEVICE(CMD, 0x0244), BID_SIL3132 },
{ } /* terminate list */
};
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH #upstream-fixes] sata_sil24: add DIDs for adaptec flavors
2008-07-02 2:52 [PATCH #upstream-fixes] sata_sil24: add DIDs for adaptec flavors Tejun Heo
@ 2008-07-02 7:55 ` Alan Cox
2008-07-02 8:47 ` Tejun Heo
0 siblings, 1 reply; 5+ messages in thread
From: Alan Cox @ 2008-07-02 7:55 UTC (permalink / raw)
To: Tejun Heo; +Cc: Jeff Garzik, IDE/ATA development list, Travis Read
On Wed, 02 Jul 2008 11:52:09 +0900
Tejun Heo <tj@kernel.org> wrote:
> Adaptec uses different DIDs for 3132. Add them.
>
> Reported by Travis Read.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Travis Read <ics@dark.net.au>
NAK
> { PCI_VDEVICE(CMD, 0x0242), BID_SIL3132 },
> { PCI_VDEVICE(CMD, 0x3131), BID_SIL3131 },
> { PCI_VDEVICE(CMD, 0x3531), BID_SIL3131 },
> + { PCI_VDEVICE(CMD, 0x0242), BID_SIL3132 },
> + { PCI_VDEVICE(CMD, 0x0244), BID_SIL3132 },
The first of those is a duplicate (see the top entry)
Alan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH #upstream-fixes] sata_sil24: add DIDs for adaptec flavors
2008-07-02 7:55 ` Alan Cox
@ 2008-07-02 8:47 ` Tejun Heo
2008-07-02 8:50 ` [PATCH #upstream-fixes take#2] sata_sil24: add DID for another adaptec falvor Tejun Heo
0 siblings, 1 reply; 5+ messages in thread
From: Tejun Heo @ 2008-07-02 8:47 UTC (permalink / raw)
To: Alan Cox; +Cc: Jeff Garzik, IDE/ATA development list, Travis Read
Alan Cox wrote:
> On Wed, 02 Jul 2008 11:52:09 +0900
> Tejun Heo <tj@kernel.org> wrote:
>
>> Adaptec uses different DIDs for 3132. Add them.
>>
>> Reported by Travis Read.
>>
>> Signed-off-by: Tejun Heo <tj@kernel.org>
>> Cc: Travis Read <ics@dark.net.au>
>
> NAK
>
>> { PCI_VDEVICE(CMD, 0x0242), BID_SIL3132 },
>> { PCI_VDEVICE(CMD, 0x3131), BID_SIL3131 },
>> { PCI_VDEVICE(CMD, 0x3531), BID_SIL3131 },
>> + { PCI_VDEVICE(CMD, 0x0242), BID_SIL3132 },
>> + { PCI_VDEVICE(CMD, 0x0244), BID_SIL3132 },
>
> The first of those is a duplicate (see the top entry)
Heh.. yeah. What was I thinking. Thanks for spotting it.
--
tejun
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH #upstream-fixes take#2] sata_sil24: add DID for another adaptec falvor
2008-07-02 8:47 ` Tejun Heo
@ 2008-07-02 8:50 ` Tejun Heo
2008-07-04 13:10 ` Jeff Garzik
0 siblings, 1 reply; 5+ messages in thread
From: Tejun Heo @ 2008-07-02 8:50 UTC (permalink / raw)
To: Alan Cox; +Cc: Jeff Garzik, IDE/ATA development list, Travis Read
There's another DID used for Adaptec card. Add it.
Reported by Travis Read.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Travis Read <ics@dark.net.au>
---
drivers/ata/sata_sil24.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c
index 8ee6b5b..84ffcc2 100644
--- a/drivers/ata/sata_sil24.c
+++ b/drivers/ata/sata_sil24.c
@@ -370,6 +370,7 @@ static const struct pci_device_id sil24_pci_tbl[] = {
{ PCI_VDEVICE(INTEL, 0x3124), BID_SIL3124 },
{ PCI_VDEVICE(CMD, 0x3132), BID_SIL3132 },
{ PCI_VDEVICE(CMD, 0x0242), BID_SIL3132 },
+ { PCI_VDEVICE(CMD, 0x0244), BID_SIL3132 },
{ PCI_VDEVICE(CMD, 0x3131), BID_SIL3131 },
{ PCI_VDEVICE(CMD, 0x3531), BID_SIL3131 },
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH #upstream-fixes take#2] sata_sil24: add DID for another adaptec falvor
2008-07-02 8:50 ` [PATCH #upstream-fixes take#2] sata_sil24: add DID for another adaptec falvor Tejun Heo
@ 2008-07-04 13:10 ` Jeff Garzik
0 siblings, 0 replies; 5+ messages in thread
From: Jeff Garzik @ 2008-07-04 13:10 UTC (permalink / raw)
To: Tejun Heo; +Cc: Alan Cox, IDE/ATA development list, Travis Read
Tejun Heo wrote:
> There's another DID used for Adaptec card. Add it.
>
> Reported by Travis Read.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Travis Read <ics@dark.net.au>
> ---
> drivers/ata/sata_sil24.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c
> index 8ee6b5b..84ffcc2 100644
> --- a/drivers/ata/sata_sil24.c
> +++ b/drivers/ata/sata_sil24.c
> @@ -370,6 +370,7 @@ static const struct pci_device_id sil24_pci_tbl[] = {
> { PCI_VDEVICE(INTEL, 0x3124), BID_SIL3124 },
> { PCI_VDEVICE(CMD, 0x3132), BID_SIL3132 },
> { PCI_VDEVICE(CMD, 0x0242), BID_SIL3132 },
> + { PCI_VDEVICE(CMD, 0x0244), BID_SIL3132 },
> { PCI_VDEVICE(CMD, 0x3131), BID_SIL3131 },
> { PCI_VDEVICE(CMD, 0x3531), BID_SIL3131 },
>
applied
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-07-04 13:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-02 2:52 [PATCH #upstream-fixes] sata_sil24: add DIDs for adaptec flavors Tejun Heo
2008-07-02 7:55 ` Alan Cox
2008-07-02 8:47 ` Tejun Heo
2008-07-02 8:50 ` [PATCH #upstream-fixes take#2] sata_sil24: add DID for another adaptec falvor Tejun Heo
2008-07-04 13:10 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).