From: Jeff Garzik <jeff@garzik.org>
To: kristen.c.accardi@intel.com
Cc: linux-ide@vger.kernel.org
Subject: Re: [patch 2/2] set default of ahci driver to power off unused ports
Date: Fri, 04 Jul 2008 09:02:47 -0400 [thread overview]
Message-ID: <486E1F77.6010909@garzik.org> (raw)
In-Reply-To: <20080702161407.13be7fc9@appleyard>
kristen.c.accardi@intel.com wrote:
> If the port isn't either a drive bay or an external SATA port,
> mark the port not-hotpluggable.
That's just flat out incorrect, though.
We've been hotplugging SATA cables since SATA began, when the _most
common_ hotplug case was where a port was neither a drive bay nor eSATA.
Part of the beauty of SATA is being able to just 'yank the cable'.
PORT_CMD_ESP and PORT_CMD_HPCP are positive indicators of hotplug
capability, but are not exclusively such.
So, this patch would create regressions for people in servers or
desktops or development systems that wish to retain their _existing_
ability to hotplug.
One guaranteed way to avoid regressions is to default ahci_power_save to
zero, but that's then not helpful to Linux users in general, few of
which will know of this module option and turn it on.
This is actually wandering into system-wide power policy :/
Jeff
prev parent reply other threads:[~2008-07-04 13:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080702225743.518230210@intel.com>
2008-07-02 23:14 ` [patch 1/2] allow user to power off unused ports via sysfs kristen.c.accardi
2008-07-04 12:58 ` Jeff Garzik
2008-07-11 13:50 ` Jeff Garzik
2008-07-02 23:14 ` [patch 2/2] set default of ahci driver to power off unused ports kristen.c.accardi
2008-07-04 13:02 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486E1F77.6010909@garzik.org \
--to=jeff@garzik.org \
--cc=kristen.c.accardi@intel.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).