* sata_sil: int slow_down uninitialized
@ 2008-07-05 8:58 Nigel Kukard
2008-07-05 11:20 ` Alan Cox
2008-07-05 11:33 ` Sergei Shtylyov
0 siblings, 2 replies; 3+ messages in thread
From: Nigel Kukard @ 2008-07-05 8:58 UTC (permalink / raw)
To: jgarzik; +Cc: linux-ide
[-- Attachment #1: Type: text/plain, Size: 149 bytes --]
Hi Guys,
Maybe I'm wrong, but line 247 of sata_sil...
static int slow_down;
is not initialized and used on line 540.
Is this right?
-N
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: sata_sil: int slow_down uninitialized
2008-07-05 8:58 sata_sil: int slow_down uninitialized Nigel Kukard
@ 2008-07-05 11:20 ` Alan Cox
2008-07-05 11:33 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Alan Cox @ 2008-07-05 11:20 UTC (permalink / raw)
To: Nigel Kukard; +Cc: jgarzik, linux-ide
On Sat, 05 Jul 2008 08:58:52 +0000
Nigel Kukard <nkukard@lbsd.net> wrote:
> Hi Guys,
>
> Maybe I'm wrong, but line 247 of sata_sil...
> static int slow_down;
>
> is not initialized and used on line 540.
Static variables start at zero unless initialised explicitly - C language
says that.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: sata_sil: int slow_down uninitialized
2008-07-05 8:58 sata_sil: int slow_down uninitialized Nigel Kukard
2008-07-05 11:20 ` Alan Cox
@ 2008-07-05 11:33 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2008-07-05 11:33 UTC (permalink / raw)
To: Nigel Kukard; +Cc: jgarzik, linux-ide
Hello.
Nigel Kukard wrote:
> Maybe I'm wrong, but line 247 of sata_sil...
> static int slow_down;
>
> is not initialized and used on line 540.
>
> Is this right?
>
Yes because unitialized static variables are automatically
initialzied to 0 in C.
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-07-05 11:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-05 8:58 sata_sil: int slow_down uninitialized Nigel Kukard
2008-07-05 11:20 ` Alan Cox
2008-07-05 11:33 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).