From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-ide@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH #upstream-fixes] ahci: give another shot at clearing all bits in irq_stat
Date: Sun, 06 Jul 2008 09:45:56 -0400 [thread overview]
Message-ID: <4870CC94.8090504@garzik.org> (raw)
In-Reply-To: <486EF44A.20400@kernel.org>
Tejun Heo wrote:
> Commit ea0c62f7cf70f13a67830471b613337bd0c9a62e tried to clear all
> bits in irq_stat but it didn't actually achieve that as irq_stat was
> anded with port_map right after read. This patch makes ahci driver
> always use the unmasked value to clear irq_status.
>
> While at it, add explanation on the peculiarities of ahci IRQ
> clearing.
>
> This was spotted by Linus Torvalds.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> ---
> The original report requires further investigation regarding why the
> bogus change fixed the problem but this change is the correct thing to
> do regardless.
>
> Thanks.
Belated post-holiday ACK (since it's already in).
Thanks for taking care of this, and good catch too.
prev parent reply other threads:[~2008-07-06 13:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-04 13:10 [git patches] libata fixes for .26 Jeff Garzik
2008-07-04 17:09 ` Linus Torvalds
2008-07-05 3:13 ` Tejun Heo
2008-07-05 3:18 ` Tejun Heo
2008-07-05 4:10 ` [PATCH #upstream-fixes] ahci: give another shot at clearing all bits in irq_stat Tejun Heo
2008-07-06 13:45 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4870CC94.8090504@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).