From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: "IDE/ATA development list" <linux-ide@vger.kernel.org>,
"Mathieu Bérard" <Mathieu.Berard@crans.org>
Subject: Re: [PATCH #upstream-fixes] libata-acpi: filter out DIPM enable
Date: Fri, 11 Jul 2008 09:38:43 -0400 [thread overview]
Message-ID: <48776263.3040103@garzik.org> (raw)
In-Reply-To: <4870D367.40106@kernel.org>
Tejun Heo wrote:
> Some BIOSen enable DIPM via _GTF which causes command timeouts under
> certain configuration. This didn't occur on 2.6.25 because 2.6.25
> defaulted to SRST, so _GTF wasn't executed during boot probe, so ahci
> host reset disabled DIPM and as _GTF wasn't executed after SRST, DIPM
> wasn't enabled. On 2.6.26, hardreset is used during probe and after
> probe _GTF is executed enabling DIPM and thus the failures.
>
> This patch could theoretically disable DIPM on machines which used to
> have it enabled on 2.6.25 but AFAIK ahci is currently the only driver
> which uses SATA ACPI hierarchy (_SDD) and as the host reset would have
> always disabled DIPM, this shouldn't happen.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> ---
> drivers/ata/libata-acpi.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
applied
prev parent reply other threads:[~2008-07-11 13:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-06 14:15 [PATCH #upstream-fixes] libata-acpi: filter out DIPM enable Tejun Heo
2008-07-06 15:25 ` Alan Cox
2008-07-11 13:38 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48776263.3040103@garzik.org \
--to=jeff@garzik.org \
--cc=Mathieu.Berard@crans.org \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).