Re: [RFC] [PATCH 2/7] pcmcia: use pcmcia_loop_config in pata and ide drivers

[Larry Finger <Larry.Finger@lwfinger.net>]

Dominik Brodowski wrote:
> Use the config loop helper in pata_pcmcia and ide_cs
> 
> CC: Tejun Heo <htejun@gmail.com>
> CC: Alan Cox <alan@lxorguk.ukuu.org.uk>
> CC: linux-ide@vger.kernel.org
> Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
> ---
>  drivers/ata/pata_pcmcia.c   |  171 ++++++++++++++++++++-----------------------
>  drivers/ide/legacy/ide-cs.c |  156 +++++++++++++++++++--------------------
>  2 files changed, 155 insertions(+), 172 deletions(-)

ACKed by Larry Finger <Larry.Finger@lwfinger.net> for ide-cs

There was one patch rejection when installing onto 2.6.27-rc1:

>  static int ide_config(struct pcmcia_device *link)
>  {
>      ide_info_t *info = link->priv;
> -    tuple_t tuple;
> -    struct {
> -	u_short		buf[128];
> -	cisparse_t	parse;
> -	config_info_t	conf;
> -	cistpl_cftable_entry_t dflt;
> -    } *stk = NULL;
> -    cistpl_cftable_entry_t *cfg;
> -    int pass, last_ret = 0, last_fn = 0, is_kme = 0;
> +    struct pcmcia_config_check *stk = NULL;
> +    int last_ret = 0, last_fn = 0, is_kme = 0;
>      unsigned long io_base, ctl_base;
>      ide_hwif_t *hwif;

The last line should be

 >      struct ide_host *host;



Larry