From: Tejun Heo <tj@kernel.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "David Müller" <dave.mueller@gmx.ch>,
jgarzik@pobox.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: Fix a large collection of DMA mode mismatches
Date: Sun, 03 Aug 2008 23:02:55 +0900 [thread overview]
Message-ID: <4895BA8F.4090603@kernel.org> (raw)
In-Reply-To: <20080803140826.761c2582@lxorguk.ukuu.org.uk>
Alan Cox wrote:
>>> +/* Don't open code these in drivers as there are traps. Firstly the range may
>>> + change in future hardware and specs, secondly 0xFF means 'no DMA' but is
>>> + > UDMA_0. Dyma ddreigiau */
>> I suppose "Dyma ddreigiau" is just contamination? Also, can you please
>> use similar patch formatting as other comments for consistency?
>
> No.. its essetially 'Here by Dragons', and to see if people actually read
> patch comments 8)
Ah.. Okay. English word games and Latin phrases scare me. :-)
>>> +static inline int ata_dma_enabled(struct ata_device *adev)
>>> +{
>>> + return (adev->dma_mode == 0xFF ? 0 : 1);
>>> +}
>> Wouldn't it be better to use ata_using_dma() instead like the other two?
>
> Not really fussed either way. Up to Jeff I guess.
The thing is ata_dma_enabled(dev) looks like it's testing whether the
device is capable of doing DMA while 'using' explicitly indicates the
current configuration. Well, no biggie either way.
--
tejun
next prev parent reply other threads:[~2008-08-03 14:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-01 8:18 [PATCH] libata: Fix a large collection of DMA mode mismatches Alan Cox
2008-08-01 11:56 ` David Müller
2008-08-01 22:42 ` Alan Cox
2008-08-03 4:45 ` Tejun Heo
2008-08-03 13:08 ` Alan Cox
2008-08-03 14:02 ` Tejun Heo [this message]
2008-08-22 6:28 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4895BA8F.4090603@kernel.org \
--to=tj@kernel.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dave.mueller@gmx.ch \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).