From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [Ksummit-2008-discuss] Kernel Summit request for Discussion of future of ATA (libata) and IDE Date: Wed, 06 Aug 2008 22:04:27 +0900 Message-ID: <4899A15B.8000800@gmail.com> References: <48976168.3020804@shaw.ca> <20080804205508.20a3f917@lxorguk.ukuu.org.uk> <48977200.3050307@shaw.ca> <20080804220619.76b94ceb@lxorguk.ukuu.org.uk> <4898EE70.1030604@shaw.ca> <4898F3EA.7000507@gmail.com> <48998A8B.9040109@ru.mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from ti-out-0910.google.com ([209.85.142.187]:14309 "EHLO ti-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753416AbYHFNFE (ORCPT ); Wed, 6 Aug 2008 09:05:04 -0400 Received: by ti-out-0910.google.com with SMTP id b6so972424tic.23 for ; Wed, 06 Aug 2008 06:05:02 -0700 (PDT) In-Reply-To: <48998A8B.9040109@ru.mvista.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Sergei Shtylyov Cc: Robert Hancock , Jeff Garzik , Bartlomiej Zolnierkiewicz , ksummit-2008-discuss@lists.linux-foundation.org, linux-kernel , James Bottomley , linux-ide , Alan Cox Sergei Shtylyov wrote: > Hello. > > Tejun Heo wrote: >>> +unsigned int ata_sff_data_xfer(struct ata_device *dev, unsigned char *buf, >>> + unsigned int buflen, int rw) >>> +{ >>> + struct ata_port *ap = dev->link->ap; >>> + void __iomem *data_addr = ap->ioaddr.data_addr; >>> + unsigned int words = buflen >> 2; >>> >> dwords maybe? >> > > Isn't word 32-bit in the 32-bit systems? We're not on 80[12]86 > (despite Intel/MS preference of calling 32-bit memory cells DWORDS)... Well, as most of machines are 64-bit these days, discussing whether a word means 16 or 32 bits is kind of moot. I usually just think byte, word, dword, qword and and libata and pci assume that too - ata_id_has_dword_io() and PCI configuration accessors. It's ultimately a peripheral issue either way tho. Thanks. -- tejun