From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Patrick Horn <phrh@yahoo.com>,
Russell King <rmk+lkml@arm.linux.org.uk>
Subject: Re: [PATCH 1/2] ide: don't allow DMA to be enabled if CONFIG_IDEDMA_{ICS,PCI}_AUTO=n
Date: Sun, 10 Aug 2008 20:30:21 +0400 [thread overview]
Message-ID: <489F179D.2010101@ru.mvista.com> (raw)
In-Reply-To: <200703152145.40644.bzolnier@gmail.com>
Hello.
Bartlomiej Zolnierkiewicz wrote:
> [PATCH] ide: don't allow DMA to be enabled if CONFIG_IDEDMA_{ICS,PCI}_AUTO=n
> For CONFIG_IDEDMA_{ICS,PCI}_AUTO=n and/or "ide=nodma" option the host/device
Not only that: it also would affect CompactFlash with no DMA support but
with DMA autotuning enabled in IDE core...
> are not programmed for DMA and it is also explicitly disabled by ide_set_dma()
> (->ide_dma_check returns "-1"). However the code responsible for manually
> enabling DMA ("hdparm -d 1") has a bug which results in DMA being erroneously
> enabled - ide_set_dma() incorrectly passes "0" return value to set_using_dma().
Heh, I've just run into this myself while trying to retro-fit Palmchip
BK3710 IDE driver into 2.6.18 properly.
> This may work if BIOS/firmware configured the host/device for DMA and chipset
> allows independent configuration of DMA/PIO modes but won't work after suspend
> and is generally unsafe on many chipsets (possibly including data corruption
> if the same registers are used for DMA/PIO timings).
Timeouts ensued in my case...
WBR, Sergei
prev parent reply other threads:[~2008-08-10 16:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-15 20:45 [PATCH 1/2] ide: don't allow DMA to be enabled if CONFIG_IDEDMA_{ICS,PCI}_AUTO=n Bartlomiej Zolnierkiewicz
2008-08-10 16:30 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489F179D.2010101@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phrh@yahoo.com \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).