From: Tejun Heo <teheo@novell.com>
To: Matthieu Helder <matthieu.helder@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: Initio 1623 driver question
Date: Wed, 20 Aug 2008 13:20:40 +0900 [thread overview]
Message-ID: <48AB9B98.6000105@novell.com> (raw)
In-Reply-To: <48AB0F54.5080900@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 175 bytes --]
Matthieu Helder wrote:
> I've compiled and installed the 2.6.26.2 kernel.
Can you please apply the attached patch and report the resulting
detection log?
Thanks.
--
tejun
[-- Attachment #2: inic-reset-debug.patch --]
[-- Type: text/x-patch, Size: 1360 bytes --]
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 9bef1a8..6670d4a 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -3451,6 +3451,7 @@ int sata_link_debounce(struct ata_link *link, const unsigned long *params,
/* DET stable? */
if (cur == last) {
+ ata_link_printk(link, "XXX debounce: DET stable %x\n", cur);
if (cur == 1 && time_before(jiffies, deadline))
continue;
if (time_after(jiffies,
@@ -3459,6 +3460,7 @@ int sata_link_debounce(struct ata_link *link, const unsigned long *params,
continue;
}
+ ata_link_printk(link, "XXX debounce: DET unstable %x\n", cur);
/* unstable, start over */
last = cur;
last_jiffies = jiffies;
diff --git a/drivers/ata/sata_inic162x.c b/drivers/ata/sata_inic162x.c
index 3ead02f..a215c2a 100644
--- a/drivers/ata/sata_inic162x.c
+++ b/drivers/ata/sata_inic162x.c
@@ -615,7 +615,8 @@ static int inic_hardreset(struct ata_link *link, unsigned int *class,
struct ata_port *ap = link->ap;
void __iomem *port_base = inic_port_base(ap);
void __iomem *idma_ctl = port_base + PORT_IDMA_CTL;
- const unsigned long *timing = sata_ehc_deb_timing(&link->eh_context);
+ //const unsigned long *timing = sata_ehc_deb_timing(&link->eh_context);
+ const unsigned long *timing = sata_deb_timing_long;
int rc;
/* hammer it into sane state */
next prev parent reply other threads:[~2008-08-20 4:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 18:22 Initio 1623 driver question Matthieu Helder
2008-08-20 4:20 ` Tejun Heo [this message]
2008-08-20 20:32 ` Matthieu Helder
2008-08-21 2:50 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AB9B98.6000105@novell.com \
--to=teheo@novell.com \
--cc=linux-ide@vger.kernel.org \
--cc=matthieu.helder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).