* [patch 1/1] drivers/ata/pata_it821x.c: fix warning
@ 2008-08-20 23:48 akpm
2008-08-22 6:33 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2008-08-20 23:48 UTC (permalink / raw)
To: jeff; +Cc: linux-ide, akpm, alan
From: Andrew Morton <akpm@linux-foundation.org>
drivers/ata/pata_it821x.c: In function 'it821x_port_start':
drivers/ata/pata_it821x.c:609: warning: 'mtype' may be used uninitialized in this function
Pretty horrid fix, but so's a warning..
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/ata/pata_it821x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/ata/pata_it821x.c~drivers-ata-pata_it821xc-fix-warning drivers/ata/pata_it821x.c
--- a/drivers/ata/pata_it821x.c~drivers-ata-pata_it821xc-fix-warning
+++ a/drivers/ata/pata_it821x.c
@@ -619,9 +619,9 @@ static void it821x_display_disk(int n, u
ata_id_c_string((u16 *)buf, id, 0, 41);
+ mtype = "UDMA";
if (buf[51]) {
mode = ffs(buf[51]);
- mtype = "UDMA";
} else if (buf[49]) {
mode = ffs(buf[49]);
mtype = "MWDMA";
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 1/1] drivers/ata/pata_it821x.c: fix warning
2008-08-20 23:48 [patch 1/1] drivers/ata/pata_it821x.c: fix warning akpm
@ 2008-08-22 6:33 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-08-22 6:33 UTC (permalink / raw)
To: akpm; +Cc: linux-ide, alan
akpm@linux-foundation.org wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
>
> drivers/ata/pata_it821x.c: In function 'it821x_port_start':
> drivers/ata/pata_it821x.c:609: warning: 'mtype' may be used uninitialized in this function
>
> Pretty horrid fix, but so's a warning..
>
> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
applied another patch that solves this...
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-08-22 6:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-20 23:48 [patch 1/1] drivers/ata/pata_it821x.c: fix warning akpm
2008-08-22 6:33 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).